Component updater on-demand logic with ResourceThrottle

chrome/browser/component_updater/component_updater_service.h

Index: chrome/browser/component_updater/component_updater_service.h
===================================================================
--- chrome/browser/component_updater/component_updater_service.h	(revision 231370)
+++ chrome/browser/component_updater/component_updater_service.h	(working copy)
@@ -18,8 +18,13 @@
 
 namespace net {
 class URLRequestContextGetter;
+class URLRequest;
 }
 
+namespace content {
+class ResourceThrottle;
+}
+
 class ComponentPatcher;
 
 // Component specific installers must derive from this class and implement
@@ -188,6 +193,12 @@
   // Returns a list of registered components.
   virtual void GetComponents(std::vector<CrxComponentInfo>* components) = 0;
 
+  // Returns a resource throttler. It imeans that a component will be downloaded

[Sorin Jianu, 2013/10/30 21:02:44]

imeans

[Sorin Jianu, 2013/10/30 22:09:13]

small nit, maybe say "resource throttle" instead of "resource throttler".

[cpu_(ooo_6.6-7.5), 2013/10/31 04:38:26]

Done.

+  // and installed before the resource is untrottled. Note that is this called

[waffles, 2013/10/30 21:11:20]

also, untrottled -> unthrottled

[cpu_(ooo_6.6-7.5), 2013/10/31 04:38:26]

Done.

+  // from the IO thread.
+  virtual content::ResourceThrottle* GetResourceThrottle(

[Sorin Jianu, 2013/10/30 22:09:13]

Since now this is part of the public interface of the class, how do we address
one of the past concerns: devs abusing this interface and calling ondemand
aggressively to get ahead of the queue?

[cpu_(ooo_6.6-7.5), 2013/10/31 04:38:26]

For it to work it requires a fair bit of infrastructure. It is not something one
can do by accident, but we could also friend the current client which besides
tests should be the only caller.

+      net::URLRequest* request, const char* crx_id) = 0;
+
   virtual ~ComponentUpdateService() {}
 
   // TODO(waffles): Remove PNaCl as a friend once an alternative on-demand