Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2571283002: Remove StyleDifference::needsPaintPropertyUpdate() (Closed)
Patch Set: Fix layout test failures Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index 4a7e19975a0dd0ec91583850d9788587bb995f55..d822d5bc0854174197215932566bfc13ff125bdf 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -586,12 +586,10 @@ StyleDifference ComputedStyle::visualInvalidationDiff(
updatePropertySpecificDifferences(other, diff);
- // The following conditions need to be at last, because they may depend on
+ // The following condition needs to be at last, because it may depend on
// conditions in diff computed above.
if (scrollAnchorDisablingPropertyChanged(other, diff))
diff.setScrollAnchorDisablingPropertyChanged();
- if (diffNeedsPaintPropertyUpdate(other, diff))
- diff.setNeedsPaintPropertyUpdate();
// Cursors are not checked, since they will be set appropriately in response
// to mouse events, so they don't need to cause any paint invalidation or
@@ -1132,17 +1130,6 @@ void ComputedStyle::updatePropertySpecificDifferences(
diff.setCSSClipChanged();
}
-bool ComputedStyle::diffNeedsPaintPropertyUpdate(
- const ComputedStyle& other,
- const StyleDifference& diff) const {
- if (diff.transformChanged() || diff.opacityChanged() ||
- diff.zIndexChanged() || diff.filterChanged() ||
- diff.backdropFilterChanged() || diff.cssClipChanged())
- return true;
-
- return false;
-}
-
void ComputedStyle::addPaintImage(StyleImage* image) {
if (!m_rareNonInheritedData.access()->m_paintImages) {
m_rareNonInheritedData.access()->m_paintImages =
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | third_party/WebKit/Source/core/style/StyleDifference.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698