CryptoSecretBoxer cleanup changes.

CryptoSecretBoxer cleanup changes.
+ Keep the .h in sync with the internal source tree.
+ Moved encrypter_ and decrypter_ back to local variables in the Box and
  Unbox methods.
+ Fixed comments from wtc in https://codereview.chromium.org/213473003/

R=wtc@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266830

[ramant (doing other things), 2014-04-29 00:41:48]

Hi Wan-Teh,
  Could you please take another look at this CL.

  Added DISALLOW_COPY_AND_ASSIGN statement to the CryptoSecretBoxer class (will
merge that change into the internal source).

  Verified this change, would not undo comments in the following Patch Set
(except making encrypter_ and decrypter_ member variables).

https://codereview.chromium.org/213473003/diff/20001/net/quic/crypto/crypto_s...

thanks
raman

https://codereview.chromium.org/257123002/diff/20001/net/quic/crypto/crypto_s...
File net/quic/crypto/crypto_secret_boxer.cc (right):

https://codereview.chromium.org/257123002/diff/20001/net/quic/crypto/crypto_s...
net/quic/crypto/crypto_secret_boxer.cc:40: key_ = key.as_string();
SetKey code is similar to the internal source.

https://codereview.chromium.org/257123002/diff/20001/net/quic/crypto/crypto_s...
File net/quic/crypto/crypto_secret_boxer.h (right):

https://codereview.chromium.org/257123002/diff/20001/net/quic/crypto/crypto_s...
net/quic/crypto/crypto_secret_boxer.h:22: CryptoSecretBoxer() {}
Will merge this line into internal source tree.

https://codereview.chromium.org/257123002/diff/20001/net/quic/crypto/crypto_s...
net/quic/crypto/crypto_secret_boxer.h:48:
DISALLOW_COPY_AND_ASSIGN(CryptoSecretBoxer);
Will merge this line into internal source tree.

[wtc, 2014-04-29 01:33:54]

lgtm

[ramant (doing other things), 2014-04-29 01:41:39]

On 2014/04/29 01:33:54, wtc wrote:
> lgtm

Thanks much Wan-Teh,
raman

[ramant (doing other things), 2014-04-29 01:41:42]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-04-29 01:43:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/257123002/20001

[commit-bot: I haz the power, 2014-04-29 01:55:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 01:55:57]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_x64_rel

[ramant (doing other things), 2014-04-29 02:36:12]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-04-29 02:37:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/257123002/20001

[commit-bot: I haz the power, 2014-04-29 03:27:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 03:27:50]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[ramant (doing other things), 2014-04-29 04:51:43]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-04-29 04:52:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/257123002/20001

[commit-bot: I haz the power, 2014-04-29 10:24:07]

Change committed as 266830