chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java - Issue 2570913003: [Android NTP] Move dismissing items into the TreeNode interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

Issue 2570913003: [Android NTP] Move dismissing items into the TreeNode interface. (Closed)

Patch Set: comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

index a8c1ca1d5ac780a18312cbf99f143ace0fd33b3d..15a6ffe2f6d49c7a8ab916bdd3fd98fa14287d0b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

@@ -10,6 +10,7 @@ import android.support.annotation.Nullable;

import android.support.annotation.StringRes;

import android.support.v7.widget.RecyclerView;

+import org.chromium.base.Callback;

import org.chromium.base.ContextUtils;

import org.chromium.base.VisibleForTesting;

import org.chromium.base.metrics.RecordUserAction;

@@ -114,13 +115,15 @@ public class SignInPromo extends OptionalLeaf

}

/** Hides the sign in promo and sets a preference to make sure it is not shown again. */

- public void dismiss() {

+ @Override

+ public void dismiss(Callback<String> itemRemovedCallback) {

mDismissed = true;

setVisible(false);

ChromePreferenceManager.getInstance(ContextUtils.getApplicationContext())

.setNewTabPageSigninPromoDismissed(true);

mObserver.unregister();

+ itemRemovedCallback.onResult(ContextUtils.getApplicationContext().getString(getHeader()));

}

@VisibleForTesting