chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ChildNode.java - Issue 2570913003: [Android NTP] Move dismissing items into the TreeNode interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ChildNode.java

Issue 2570913003: [Android NTP] Move dismissing items into the TreeNode interface. (Closed)

Patch Set: comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ChildNode.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ChildNode.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ChildNode.java

index 0aaf26ff2bb1cf7c080b9fa7b9185152416ba09b..e293b674dadd66ed2e748555db7e0a73da80c6cc 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ChildNode.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ChildNode.java

@@ -45,4 +45,10 @@ public abstract class ChildNode implements TreeNode {

protected void notifyItemRemoved(int index) {

notifyItemRangeRemoved(index, 1);

}

+ protected void checkIndex(int position) {

+ if (position < 0 || position >= getItemCount()) {

+ throw new IndexOutOfBoundsException(position + "/" + getItemCount());

+ }

}