Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: ui/events/latency_info.cc

Issue 2570893003: Clean up LatencyInfo and RWHLatencyTracker. (Closed)
Patch Set: Avoid introducing new bare calls to FactoryGet. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/events/latency_info.h ('k') | ui/events/mojo/latency_info.mojom » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/events/latency_info.h" 5 #include "ui/events/latency_info.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <string> 10 #include <string>
(...skipping 22 matching lines...) Expand all
33 CASE_TYPE(INPUT_EVENT_LATENCY_RENDERING_SCHEDULED_IMPL_COMPONENT); 33 CASE_TYPE(INPUT_EVENT_LATENCY_RENDERING_SCHEDULED_IMPL_COMPONENT);
34 CASE_TYPE(INPUT_EVENT_LATENCY_FORWARD_SCROLL_UPDATE_TO_MAIN_COMPONENT); 34 CASE_TYPE(INPUT_EVENT_LATENCY_FORWARD_SCROLL_UPDATE_TO_MAIN_COMPONENT);
35 CASE_TYPE(INPUT_EVENT_LATENCY_ACK_RWH_COMPONENT); 35 CASE_TYPE(INPUT_EVENT_LATENCY_ACK_RWH_COMPONENT);
36 CASE_TYPE(WINDOW_SNAPSHOT_FRAME_NUMBER_COMPONENT); 36 CASE_TYPE(WINDOW_SNAPSHOT_FRAME_NUMBER_COMPONENT);
37 CASE_TYPE(TAB_SHOW_COMPONENT); 37 CASE_TYPE(TAB_SHOW_COMPONENT);
38 CASE_TYPE(INPUT_EVENT_LATENCY_RENDERER_MAIN_COMPONENT); 38 CASE_TYPE(INPUT_EVENT_LATENCY_RENDERER_MAIN_COMPONENT);
39 CASE_TYPE(INPUT_EVENT_LATENCY_RENDERER_SWAP_COMPONENT); 39 CASE_TYPE(INPUT_EVENT_LATENCY_RENDERER_SWAP_COMPONENT);
40 CASE_TYPE(INPUT_EVENT_BROWSER_RECEIVED_RENDERER_SWAP_COMPONENT); 40 CASE_TYPE(INPUT_EVENT_BROWSER_RECEIVED_RENDERER_SWAP_COMPONENT);
41 CASE_TYPE(INPUT_EVENT_GPU_SWAP_BUFFER_COMPONENT); 41 CASE_TYPE(INPUT_EVENT_GPU_SWAP_BUFFER_COMPONENT);
42 CASE_TYPE(INPUT_EVENT_LATENCY_GENERATE_SCROLL_UPDATE_FROM_MOUSE_WHEEL); 42 CASE_TYPE(INPUT_EVENT_LATENCY_GENERATE_SCROLL_UPDATE_FROM_MOUSE_WHEEL);
43 CASE_TYPE(INPUT_EVENT_LATENCY_TERMINATED_MOUSE_COMPONENT); 43 CASE_TYPE(INPUT_EVENT_LATENCY_TERMINATED_NO_SWAP_COMPONENT);
44 CASE_TYPE(INPUT_EVENT_LATENCY_TERMINATED_MOUSE_WHEEL_COMPONENT);
45 CASE_TYPE(INPUT_EVENT_LATENCY_TERMINATED_KEYBOARD_COMPONENT);
46 CASE_TYPE(INPUT_EVENT_LATENCY_TERMINATED_TOUCH_COMPONENT);
47 CASE_TYPE(INPUT_EVENT_LATENCY_TERMINATED_GESTURE_COMPONENT);
48 CASE_TYPE(INPUT_EVENT_LATENCY_TERMINATED_FRAME_SWAP_COMPONENT); 44 CASE_TYPE(INPUT_EVENT_LATENCY_TERMINATED_FRAME_SWAP_COMPONENT);
49 CASE_TYPE(INPUT_EVENT_LATENCY_TERMINATED_COMMIT_FAILED_COMPONENT); 45 CASE_TYPE(INPUT_EVENT_LATENCY_TERMINATED_COMMIT_FAILED_COMPONENT);
50 CASE_TYPE(INPUT_EVENT_LATENCY_TERMINATED_COMMIT_NO_UPDATE_COMPONENT); 46 CASE_TYPE(INPUT_EVENT_LATENCY_TERMINATED_COMMIT_NO_UPDATE_COMPONENT);
51 CASE_TYPE(INPUT_EVENT_LATENCY_TERMINATED_SWAP_FAILED_COMPONENT); 47 CASE_TYPE(INPUT_EVENT_LATENCY_TERMINATED_SWAP_FAILED_COMPONENT);
52 default: 48 default:
53 DLOG(WARNING) << "Unhandled LatencyComponentType.\n"; 49 DLOG(WARNING) << "Unhandled LatencyComponentType.\n";
54 break; 50 break;
55 } 51 }
56 #undef CASE_TYPE 52 #undef CASE_TYPE
57 return "unknown"; 53 return "unknown";
58 } 54 }
59 55
60 bool IsTerminalComponent(ui::LatencyComponentType type) { 56 bool IsTerminalComponent(ui::LatencyComponentType type) {
61 switch (type) { 57 switch (type) {
62 case ui::INPUT_EVENT_LATENCY_TERMINATED_MOUSE_COMPONENT: 58 case ui::INPUT_EVENT_LATENCY_TERMINATED_NO_SWAP_COMPONENT:
63 case ui::INPUT_EVENT_LATENCY_TERMINATED_MOUSE_WHEEL_COMPONENT:
64 case ui::INPUT_EVENT_LATENCY_TERMINATED_KEYBOARD_COMPONENT:
65 case ui::INPUT_EVENT_LATENCY_TERMINATED_TOUCH_COMPONENT:
66 case ui::INPUT_EVENT_LATENCY_TERMINATED_GESTURE_COMPONENT:
67 case ui::INPUT_EVENT_LATENCY_TERMINATED_FRAME_SWAP_COMPONENT: 59 case ui::INPUT_EVENT_LATENCY_TERMINATED_FRAME_SWAP_COMPONENT:
68 case ui::INPUT_EVENT_LATENCY_TERMINATED_COMMIT_FAILED_COMPONENT: 60 case ui::INPUT_EVENT_LATENCY_TERMINATED_COMMIT_FAILED_COMPONENT:
69 case ui::INPUT_EVENT_LATENCY_TERMINATED_COMMIT_NO_UPDATE_COMPONENT: 61 case ui::INPUT_EVENT_LATENCY_TERMINATED_COMMIT_NO_UPDATE_COMPONENT:
70 case ui::INPUT_EVENT_LATENCY_TERMINATED_SWAP_FAILED_COMPONENT: 62 case ui::INPUT_EVENT_LATENCY_TERMINATED_SWAP_FAILED_COMPONENT:
71 return true; 63 return true;
72 default: 64 default:
73 return false; 65 return false;
74 } 66 }
75 } 67 }
76 68
(...skipping 297 matching lines...) Expand 10 before | Expand all | Expand 10 after
374 } 366 }
375 367
376 bool LatencyInfo::AddInputCoordinate(const gfx::PointF& input_coordinate) { 368 bool LatencyInfo::AddInputCoordinate(const gfx::PointF& input_coordinate) {
377 if (input_coordinates_size_ >= kMaxInputCoordinates) 369 if (input_coordinates_size_ >= kMaxInputCoordinates)
378 return false; 370 return false;
379 input_coordinates_[input_coordinates_size_++] = input_coordinate; 371 input_coordinates_[input_coordinates_size_++] = input_coordinate;
380 return true; 372 return true;
381 } 373 }
382 374
383 } // namespace ui 375 } // namespace ui
OLDNEW
« no previous file with comments | « ui/events/latency_info.h ('k') | ui/events/mojo/latency_info.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698