src/full-codegen/full-codegen.cc - Issue 2570843002: Fix usage of literal cloning for large double arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/full-codegen.cc

Issue 2570843002: Fix usage of literal cloning for large double arrays. (Closed)

Patch Set: Add missing flag. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/full-codegen.cc

diff --git a/src/full-codegen/full-codegen.cc b/src/full-codegen/full-codegen.cc

index 20eb47e05652d3d40e9d8700d296a35b459b5d00..444dd8ec25d86f6b2b6d6a8487fa6d733fd25816 100644

--- a/src/full-codegen/full-codegen.cc

+++ b/src/full-codegen/full-codegen.cc

@@ -183,8 +183,7 @@ bool FullCodeGenerator::MustCreateObjectLiteralWithRuntime(

bool FullCodeGenerator::MustCreateArrayLiteralWithRuntime(

ArrayLiteral* expr) const {

- return expr->depth() > 1 ||

- expr->values()->length() > JSArray::kInitialMaxFastElementArray;

+ return !FastCloneShallowArrayStub::IsSupported(expr);

}

void FullCodeGenerator::Initialize(uintptr_t stack_limit) {