Issue 25708004: MIPS: Improve and simplify removal of unreachable code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25708004: MIPS: Improve and simplify removal of unreachable code. (Closed)

Created:
7 years, 2 months ago by kilvadyb

Modified:
7 years, 2 months ago

Reviewers:
Michael Starzinger, Jakob Kummerow, Paul Lind, danno, kisg, palfia

CC:
v8-dev

Base URL:
git@github.com:paul99/v8m-rb.git@master

Visibility:
Public.

More Reviews

Description

MIPS: Improve and simplify removal of unreachable code. Port r17073 (ba68149) Original commit message: - Detect unreachable basic blocks of code either following an unconditional deopt or after a provably untaken branch of HBranch or HCompareObjectEqAndBranch instructions. - Emit dummy uses in unreachable blocks during Hydrogen -> Lithium translation. BUG=chromium:258519

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+40 lines, -124 lines)			Patch
src/lithium-codegen.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
src/mips/lithium-codegen-mips.h	View	8 chunks	+5 lines, -47 lines	0 comments	Download
src/mips/lithium-codegen-mips.cc	View	8 chunks	+7 lines, -64 lines	0 comments	Download
src/mips/lithium-mips.h	View	2 chunks	+5 lines, -3 lines	0 comments	Download
src/mips/lithium-mips.cc	View	3 chunks	+22 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Paul Lind

This one requires approval from v8-team as well, Jakob, Danno, Michael, can one of you ...

7 years, 2 months ago (2013-10-02 16:35:51 UTC) #3

Michael Starzinger

LGTM on the changes to the lithium-codegen.cc file.

7 years, 2 months ago (2013-10-02 16:57:45 UTC) #4

Committed as r17084.

Expand Messages | Collapse Messages