Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2570793002: Disabling flaky test on Android: WebRtcDataChannelTest.DataChannelGC. (Closed)

Created:
4 years ago by Henrik Grunell
Modified:
3 years, 11 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabling flaky test on Android: WebRtcDataChannelTest.DataChannelGC. TBR=phoglund@chromium.org BUG=673333

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/browser/webrtc/webrtc_datachannel_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Henrik Grunell
4 years ago (2016-12-13 10:22:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570793002/1
4 years ago (2016-12-13 10:22:58 UTC) #5
phoglund_chromium
lgtm
4 years ago (2016-12-13 10:40:03 UTC) #6
Guido Urdaneta
On 2016/12/13 10:40:03, phoglund_chrome wrote: > lgtm I think this test is not flaky. The ...
4 years ago (2016-12-13 10:48:16 UTC) #8
Henrik Grunell
On 2016/12/13 10:48:16, Guido Urdaneta wrote: > On 2016/12/13 10:40:03, phoglund_chrome wrote: > > lgtm ...
4 years ago (2016-12-13 11:17:26 UTC) #9
Guido Urdaneta
On 2016/12/13 11:17:26, Henrik Grunell wrote: > On 2016/12/13 10:48:16, Guido Urdaneta wrote: > > ...
4 years ago (2016-12-13 12:03:27 UTC) #10
Guido Urdaneta
On 2016/12/13 12:03:27, Guido Urdaneta wrote: > On 2016/12/13 11:17:26, Henrik Grunell wrote: > > ...
4 years ago (2016-12-13 12:15:25 UTC) #11
Henrik Grunell
On 2016/12/13 12:15:25, Guido Urdaneta wrote: > On 2016/12/13 12:03:27, Guido Urdaneta wrote: > > ...
4 years ago (2016-12-13 12:23:48 UTC) #12
Henrik Grunell
4 years ago (2016-12-13 12:24:38 UTC) #13 
On 2016/12/13 12:23:48, Henrik Grunell wrote:
> On 2016/12/13 12:15:25, Guido Urdaneta wrote:
> > On 2016/12/13 12:03:27, Guido Urdaneta wrote:
> > > On 2016/12/13 11:17:26, Henrik Grunell wrote:
> > > > On 2016/12/13 10:48:16, Guido Urdaneta wrote:
> > > > > On 2016/12/13 10:40:03, phoglund_chrome wrote:
> > > > > > lgtm
> > > > > 
> > > > > I think this test is not flaky.
> > > > > The "flaky" runs reported in the bug have hundreds of failed tests, so
> > > cannot
> > > > be
> > > > > something specific to this test.
> > > > > See
> > > > >
> > > >
> > >
> >
>
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...
> > > > >
> > > >
> > >
> >
>
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...
> > > > >
> > > >
> > >
> >
>
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...
> > > > >
> > > >
> > >
> >
>
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...
> > > > >
> > > >
> > >
> >
>
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...
> > > > 
> > > > Yes, I noticed that. But I think the other tests failing is something
else
> > > > because the summary says:
> > > > 
> > > > C  959.864s Main  Summary
> > > > C  959.864s Main 
> > > >
> > >
> >
>
********************************************************************************
> > > > C  959.866s Main  [==========] 1502 tests ran.
> > > > C  959.866s Main  [  PASSED  ] 1249 tests.
> > > > C  959.866s Main  [  FAILED  ] 2 tests, listed below:
> > > > C  959.866s Main  [  FAILED  ]
> > > >
> BackgroundSyncBrowserTest.SyncRegistrationFromSWDeletedWhenClearingSiteData
> > > > (TIMEOUT)
> > > > C  959.866s Main  [  FAILED  ] WebRtcDataChannelTest.DataChannelGC
> (TIMEOUT)
> > > > C  959.866s Main  
> > > > C  959.866s Main  2 FAILED TESTS
> > > > 
> > > > And if we look at the first "failure",
> > > > AccessibilityActionBrowserTest.CanvasGetImageScale:
> > > > 
> > > > I  843.658s run_tests_on_device(01ab5ac2032fd33a)  [ RUN      ]
> > > > AccessibilityActionBrowserTest.CanvasGetImageScale
> > > > I  843.658s run_tests_on_device(01ab5ac2032fd33a) 
> > > > [WARNING:dns_config_service_posix.cc(316)] Failed to read DnsConfig.
> > > > I  843.658s run_tests_on_device(01ab5ac2032fd33a) 
> > > > [ERROR:devtools_http_handler.cc(221)] Cannot start http server for
> devtools.
> > > > Stop devtools.
> > > > I  843.658s run_tests_on_device(01ab5ac2032fd33a)  [       OK ]
> > > > AccessibilityActionBrowserTest.CanvasGetImageScale (1845 ms)
> > > > 
> > > > So those others is something else.
> > > 
> > > I think we need flaky failures in more reliable runs to justify disabling
> > this.
> > > The flakiness dashboard for this test looks good.
> > >
> >
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...
> > 
> > Also, depending on the run, there are different failures reported.
> > I saw this one, for example:
> > 
> > ERROR:root:Forwarding signal 15 to test process
> > C  959.844s Main  Received SIGTERM. Stopping test execution.
> > C  959.851s Main 
> >
>
********************************************************************************
> > C  959.851s Main  Detailed Logs
> > C  959.851s Main 
> >
>
********************************************************************************
> > C  959.854s Main  [TIMEOUT] DownloadContentTest.CancelResumedDownload:
> > C  959.854s Main    Suite execution terminated, probably due to swarming
> > timeout.
> > C  959.854s Main    Your test may not have run.
> > C  959.854s Main  [TIMEOUT] WebRtcDataChannelTest.DataChannelGC:
> > C  959.854s Main    Suite execution terminated, probably due to swarming
> > timeout.
> > C  959.854s Main    Your test may not have run.
> > C  959.854s Main  [TIMEOUT] WebRtcMediaRecorderTest.PeerConnection/5:
> > C  959.854s Main    Suite execution terminated, probably due to swarming
> > timeout.
> > C  959.854s Main    Your test may not have run.
> > C  959.854s Main  [TIMEOUT] WebRtcMediaRecorderTest.StartWithTimeSlice/3:
> > C  959.854s Main    Suite execution terminated, probably due to swarming
> > timeout.
> > C  959.854s Main    Your test may not have run.
> > C  959.854s Main 
> >
>
********************************************************************************
> > C  959.854s Main  Summary
> > C  959.854s Main 
> >
>
********************************************************************************
> > C  959.857s Main  [==========] 1510 tests ran.
> > C  959.857s Main  [  PASSED  ] 1255 tests.
> > C  959.857s Main  [  FAILED  ] 4 tests, listed below:
> > C  959.857s Main  [  FAILED  ] DownloadContentTest.CancelResumedDownload
> > (TIMEOUT)
> > C  959.857s Main  [  FAILED  ] WebRtcDataChannelTest.DataChannelGC (TIMEOUT)
> > C  959.857s Main  [  FAILED  ] WebRtcMediaRecorderTest.PeerConnection/5
> > (TIMEOUT)
> > C  959.857s Main  [  FAILED  ] WebRtcMediaRecorderTest.StartWithTimeSlice/3
> > (TIMEOUT)
> > 
> > I don't think those problematic runs are reason enough to disable this test.
> 
> I'll move the comments to the bug, let's continue there.

Ah, OK I saw now you already commented there.

Powered by Google App Engine
This is Rietveld 408576698