Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2570783006: DevTools: convert a few more icons to UI.Icon. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
index cb7fe590c27e7ccb3ea080ed418494a4d7357b59..437a4ed353ce634f184987612aba42fd6bcaf285 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -312,7 +312,10 @@ Console.ConsoleViewMessage = class {
var contentElement = toggleElement.createChild('div', 'console-message-stack-trace-wrapper');
var messageElement = this._buildMessage(consoleMessage);
+ var icon = UI.Icon.create('smallicon-triangle-right', 'stack-trace-expand-icon');
var clickableElement = contentElement.createChild('div');
+ clickableElement.appendChild(icon);
+
clickableElement.appendChild(messageElement);
var stackTraceElement = contentElement.createChild('div');
var stackTracePreview =
@@ -324,8 +327,8 @@ Console.ConsoleViewMessage = class {
* @param {boolean} expand
*/
function expandStackTrace(expand) {
+ icon.setIconType(expand ? 'smallicon-triangle-bottom' : 'smallicon-triangle-right');
stackTraceElement.classList.toggle('hidden', !expand);
- toggleElement.classList.toggle('expanded', expand);
}
/**

Powered by Google App Engine
This is Rietveld 408576698