Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: components/grpc_support/bidirectional_stream_unittest.cc

Issue 2570783005: Disable flaky test BidirectionalStreamDelayRequestHeadersUntilFlush/BidirectionalStreamTest.StreamF… (Closed)
Patch Set: git cl format. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/grpc_support/bidirectional_stream_unittest.cc
diff --git a/components/grpc_support/bidirectional_stream_unittest.cc b/components/grpc_support/bidirectional_stream_unittest.cc
index 3ef83ffe9c1cf2fc7e768ebc82efc25078a10cdb..ec67198e44386c8a794acd6defb003c2f2f50c89 100644
--- a/components/grpc_support/bidirectional_stream_unittest.cc
+++ b/components/grpc_support/bidirectional_stream_unittest.cc
@@ -530,7 +530,17 @@ TEST_P(BidirectionalStreamTest, ReadFailsBeforeRequestStarted) {
bidirectional_stream_destroy(test.stream);
}
-TEST_P(BidirectionalStreamTest, StreamFailBeforeReadIsExecutedOnNetworkThread) {
+// Flaky on Android. http://crbug.com/674128
+#if defined(OS_ANDROID)
+#define MAYBE_StreamFailBeforeReadIsExecutedOnNetworkThread \
+ DISABLED_StreamFailBeforeReadIsExecutedOnNetworkThread
+#else
+#define MAYBE_StreamFailBeforeReadIsExecutedOnNetworkThread \
+ StreamFailBeforeReadIsExecutedOnNetworkThread
+#endif
+
+TEST_P(BidirectionalStreamTest,
+ MAYBE_StreamFailBeforeReadIsExecutedOnNetworkThread) {
class CustomTestBidirectionalStreamCallback
: public TestBidirectionalStreamCallback {
bool MaybeCancel(bidirectional_stream* stream, ResponseStep step) override {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698