components/ntp_tiles/webui/popular_sites_internals_message_handler.cc - Issue 2570783003: [Popular Sites] Split PopularSites interface and PopularSitesImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_tiles/webui/popular_sites_internals_message_handler.cc

Issue 2570783003: [Popular Sites] Split PopularSites interface and PopularSitesImpl (Closed)

Patch Set: Rebased and minor naming change. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_tiles/webui/ntp_tiles_internals_message_handler.cc ('k') | ios/chrome/browser/ntp_tiles/ios_popular_sites_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_tiles/webui/popular_sites_internals_message_handler.cc

diff --git a/components/ntp_tiles/webui/popular_sites_internals_message_handler.cc b/components/ntp_tiles/webui/popular_sites_internals_message_handler.cc

index 50f2252944bbe954f59f3c8adda4eaeb2e674a61..ce021454ae6b71da9caef6c804176ce20e24c45f 100644

--- a/components/ntp_tiles/webui/popular_sites_internals_message_handler.cc

+++ b/components/ntp_tiles/webui/popular_sites_internals_message_handler.cc

@@ -152,7 +152,7 @@ void PopularSitesInternalsMessageHandler::SendSites() {

base::DictionaryValue result;

result.Set("sites", std::move(sites_list));

- result.SetString("url", popular_sites_->LastURL().spec());

+ result.SetString("url", popular_sites_->GetLastURLFetched().spec());

web_ui_->CallJavascriptFunction("chrome.popular_sites_internals.receiveSites",

result);

}