Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: ios/chrome/browser/ui/webui/popular_sites_internals_ui.cc

Issue 2570783003: [Popular Sites] Split PopularSites interface and PopularSitesImpl (Closed)
Patch Set: Split PopularSitesImpl. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ios/chrome/browser/ui/webui/popular_sites_internals_ui.h" 5 #include "ios/chrome/browser/ui/webui/popular_sites_internals_ui.h"
6 6
7 #include "components/grit/components_resources.h" 7 #include "components/grit/components_resources.h"
8 #include "components/ntp_tiles/popular_sites.h" 8 #include "components/ntp_tiles/popular_sites.h"
9 #include "components/ntp_tiles/webui/popular_sites_internals_message_handler.h" 9 #include "components/ntp_tiles/webui/popular_sites_internals_message_handler.h"
10 #include "components/ntp_tiles/webui/popular_sites_internals_message_handler_cli ent.h" 10 #include "components/ntp_tiles/webui/popular_sites_internals_message_handler_cli ent.h"
(...skipping 13 matching lines...) Expand all
24 public ntp_tiles::PopularSitesInternalsMessageHandlerClient { 24 public ntp_tiles::PopularSitesInternalsMessageHandlerClient {
25 public: 25 public:
26 IOSPopularSitesInternalsMessageHandlerBridge() : handler_(this) {} 26 IOSPopularSitesInternalsMessageHandlerBridge() : handler_(this) {}
27 27
28 private: 28 private:
29 // web::WebUIIOSMessageHandler: 29 // web::WebUIIOSMessageHandler:
30 void RegisterMessages() override; 30 void RegisterMessages() override;
31 31
32 // ntp_tiles::PopularSitesInternalsMessageHandlerClient 32 // ntp_tiles::PopularSitesInternalsMessageHandlerClient
33 base::SequencedWorkerPool* GetBlockingPool() override; 33 base::SequencedWorkerPool* GetBlockingPool() override;
34 std::unique_ptr<ntp_tiles::PopularSites> MakePopularSites() override; 34 std::unique_ptr<ntp_tiles::PopularSitesImpl> MakePopularSites() override;
35 PrefService* GetPrefs() override; 35 PrefService* GetPrefs() override;
36 void RegisterMessageCallback( 36 void RegisterMessageCallback(
37 const std::string& message, 37 const std::string& message,
38 const base::Callback<void(const base::ListValue*)>& callback) override; 38 const base::Callback<void(const base::ListValue*)>& callback) override;
39 void CallJavascriptFunctionVector( 39 void CallJavascriptFunctionVector(
40 const std::string& name, 40 const std::string& name,
41 const std::vector<const base::Value*>& values) override; 41 const std::vector<const base::Value*>& values) override;
42 42
43 ntp_tiles::PopularSitesInternalsMessageHandler handler_; 43 ntp_tiles::PopularSitesInternalsMessageHandler handler_;
44 44
45 DISALLOW_COPY_AND_ASSIGN(IOSPopularSitesInternalsMessageHandlerBridge); 45 DISALLOW_COPY_AND_ASSIGN(IOSPopularSitesInternalsMessageHandlerBridge);
46 }; 46 };
47 47
48 void IOSPopularSitesInternalsMessageHandlerBridge::RegisterMessages() { 48 void IOSPopularSitesInternalsMessageHandlerBridge::RegisterMessages() {
49 handler_.RegisterMessages(); 49 handler_.RegisterMessages();
50 } 50 }
51 51
52 base::SequencedWorkerPool* 52 base::SequencedWorkerPool*
53 IOSPopularSitesInternalsMessageHandlerBridge::GetBlockingPool() { 53 IOSPopularSitesInternalsMessageHandlerBridge::GetBlockingPool() {
54 return web::WebThread::GetBlockingPool(); 54 return web::WebThread::GetBlockingPool();
55 } 55 }
56 56
57 std::unique_ptr<ntp_tiles::PopularSites> 57 std::unique_ptr<ntp_tiles::PopularSitesImpl>
58 IOSPopularSitesInternalsMessageHandlerBridge::MakePopularSites() { 58 IOSPopularSitesInternalsMessageHandlerBridge::MakePopularSites() {
59 return IOSPopularSitesFactory::NewForBrowserState( 59 return IOSPopularSitesFactory::NewForBrowserState(
60 ios::ChromeBrowserState::FromWebUIIOS(web_ui())); 60 ios::ChromeBrowserState::FromWebUIIOS(web_ui()));
61 } 61 }
62 62
63 PrefService* IOSPopularSitesInternalsMessageHandlerBridge::GetPrefs() { 63 PrefService* IOSPopularSitesInternalsMessageHandlerBridge::GetPrefs() {
64 return ios::ChromeBrowserState::FromWebUIIOS(web_ui())->GetPrefs(); 64 return ios::ChromeBrowserState::FromWebUIIOS(web_ui())->GetPrefs();
65 } 65 }
66 66
67 void IOSPopularSitesInternalsMessageHandlerBridge::RegisterMessageCallback( 67 void IOSPopularSitesInternalsMessageHandlerBridge::RegisterMessageCallback(
(...skipping 23 matching lines...) Expand all
91 } 91 }
92 92
93 PopularSitesInternalsUI::PopularSitesInternalsUI(web::WebUIIOS* web_ui) 93 PopularSitesInternalsUI::PopularSitesInternalsUI(web::WebUIIOS* web_ui)
94 : web::WebUIIOSController(web_ui) { 94 : web::WebUIIOSController(web_ui) {
95 web::WebUIIOSDataSource::Add(ios::ChromeBrowserState::FromWebUIIOS(web_ui), 95 web::WebUIIOSDataSource::Add(ios::ChromeBrowserState::FromWebUIIOS(web_ui),
96 CreatePopularSitesInternalsHTMLSource()); 96 CreatePopularSitesInternalsHTMLSource());
97 web_ui->AddMessageHandler(new IOSPopularSitesInternalsMessageHandlerBridge); 97 web_ui->AddMessageHandler(new IOSPopularSitesInternalsMessageHandlerBridge);
98 } 98 }
99 99
100 PopularSitesInternalsUI::~PopularSitesInternalsUI() {} 100 PopularSitesInternalsUI::~PopularSitesInternalsUI() {}
OLDNEW
« components/ntp_tiles/popular_sites.h ('K') | « ios/chrome/browser/prefs/browser_prefs.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698