chrome/browser/ntp_tiles/chrome_popular_sites_factory.cc - Issue 2570783003: [Popular Sites] Split PopularSites interface and PopularSitesImpl

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ntp_tiles/chrome_popular_sites_factory.cc

Issue 2570783003: [Popular Sites] Split PopularSites interface and PopularSitesImpl (Closed)

Patch Set: Rebased and minor naming change. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/browser/prefs/browser_prefs.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ntp_tiles/chrome_popular_sites_factory.h"	5 #include "chrome/browser/ntp_tiles/chrome_popular_sites_factory.h"

6	6

7 #include "base/bind.h"	7 #include "base/bind.h"

8 #include "base/memory/ptr_util.h"	8 #include "base/memory/ptr_util.h"

9 #include "base/path_service.h"	9 #include "base/path_service.h"

10 #include "chrome/browser/browser_process.h"	10 #include "chrome/browser/browser_process.h"

11 #include "chrome/browser/profiles/profile.h"	11 #include "chrome/browser/profiles/profile.h"

12 #include "chrome/browser/search_engines/template_url_service_factory.h"	12 #include "chrome/browser/search_engines/template_url_service_factory.h"

13 #include "chrome/common/chrome_paths.h"	13 #include "chrome/common/chrome_paths.h"

14 #include "components/ntp_tiles/popular_sites.h"	14 #include "components/ntp_tiles/popular_sites.h"

15 #include "components/safe_json/safe_json_parser.h"	15 #include "components/safe_json/safe_json_parser.h"

16 #include "content/public/browser/browser_thread.h"	16 #include "content/public/browser/browser_thread.h"

17	17

18 std::unique_ptr<ntp_tiles::PopularSites>	18 std::unique_ptr<ntp_tiles::PopularSites>

19 ChromePopularSitesFactory::NewForProfile(Profile* profile) {	19 ChromePopularSitesFactory::NewForProfile(Profile* profile) {

20 base::FilePath directory; // remains empty if PathService::Get() fails.	20 base::FilePath directory; // remains empty if PathService::Get() fails.

21 PathService::Get(chrome::DIR_USER_DATA, &directory);	21 PathService::Get(chrome::DIR_USER_DATA, &directory);

22 return base::MakeUnique<ntp_tiles::PopularSites>(	22 return base::MakeUnique<ntp_tiles::PopularSitesImpl>(

23 content::BrowserThread::GetBlockingPool(), profile->GetPrefs(),	23 content::BrowserThread::GetBlockingPool(), profile->GetPrefs(),

24 TemplateURLServiceFactory::GetForProfile(profile),	24 TemplateURLServiceFactory::GetForProfile(profile),

25 g_browser_process->variations_service(), profile->GetRequestContext(),	25 g_browser_process->variations_service(), profile->GetRequestContext(),

26 directory, base::Bind(safe_json::SafeJsonParser::Parse));	26 directory, base::Bind(safe_json::SafeJsonParser::Parse));

27 }	27 }

OLD	NEW