Issue 2570763002: Fixed bad calculations for determining total allocated size of a zone.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2570763002: Fixed bad calculations for determining total allocated size of a zone. (Closed)

Created:
4 years ago by bkonyi

Modified:
4 years ago

Reviewers:
zra, Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -9 lines)			Patch
M	runtime/vm/thread_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/zone.h	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	runtime/vm/zone.cc	View	2 chunks	+18 lines, -2 lines	0 comments	Download
M	runtime/vm/zone_test.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

bkonyi

Looks like I misunderstood what Zone::SizeInBytes() was actually doing and assumed it returned the capacity ...

4 years ago (2016-12-13 01:34:36 UTC) #2

bkonyi

4 years ago (2016-12-13 01:49:06 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a3ec04eb99fac7ecfff974646c7335e957f0e271 (presubmit successful).