Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2570723002: For SPv2, move updateAnimations() to follow scrolling and paint invalidation. (Closed)
Patch Set: Move updateAnimations to follow updatePaintProperties. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index e1b62509b08c745affd26a7a3a85dcc10a194dd6..84f4946dba1d674fa331ca3a2a0ec308034fe441 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -2873,8 +2873,6 @@ void FrameView::updateLifecyclePhasesInternal(
if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
view.compositor()->updateIfNeededRecursive();
} else {
- DocumentAnimations::updateAnimations(layoutView()->document());
-
forAllNonThrottledFrameViews([](FrameView& frameView) {
frameView.layoutView()->layer()->updateDescendantDependentFlags();
frameView.layoutView()->commitPendingSelection();
@@ -2904,6 +2902,9 @@ void FrameView::updateLifecyclePhasesInternal(
updatePaintProperties();
}
+ if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
+ DocumentAnimations::updateAnimations(layoutView()->document());
wkorman 2016/12/15 20:14:04 Two notes: 1. This moves some work that used to b
+
if (targetState == DocumentLifecycle::PaintClean) {
if (!m_frame->document()->printing())
synchronizedPaint();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698