Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2570723002: For SPv2, move updateAnimations() to follow scrolling and paint invalidation. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index 196f562691e386f9bdd7377e29038afb9aec1869..f79f35b263359fb6474db16ea5d694dba2d4c38b 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -2873,8 +2873,6 @@ void FrameView::updateLifecyclePhasesInternal(
if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
view.compositor()->updateIfNeededRecursive();
} else {
- DocumentAnimations::updateAnimations(layoutView()->document());
-
forAllNonThrottledFrameViews([](FrameView& frameView) {
frameView.layoutView()->layer()->updateDescendantDependentFlags();
frameView.layoutView()->commitPendingSelection();
@@ -2898,6 +2896,9 @@ void FrameView::updateLifecyclePhasesInternal(
updateCompositedSelectionIfNeeded();
}
+
+ if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
+ DocumentAnimations::updateAnimations(layoutView()->document());
chrishtr 2016/12/13 00:13:53 It needs to be after updatePaintProperties, if ani
wkorman 2016/12/15 20:14:04 Indeed. Done.
}
if (targetState >= DocumentLifecycle::PrePaintClean) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698