Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2570693002: Fix base::CopyDirectory() and JumpListIcons(Old) folders' operation logic (Closed)
Patch Set: Mark retired metrics as obselete rather than deleting them Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « chrome/browser/win/jumplist.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index f01549cc4f4725adacd5e1d3b19e9c97220cec33..979006681bc6e68c5c1c3f2cae6af2233eaf0929 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -74749,16 +74749,17 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<summary>The type of category clicked in the Windows Jumplist</summary>
</histogram>
-<histogram name="WinJumplist.DetailedFolderMoveResults"
- enum="JumplistIconsDetailedFolderMoveCategory">
Ilya Sherman 2016/12/13 06:20:07 It still looks like you've removed the metadata fo
chengx 2016/12/13 18:46:01 Sorry I thought this could be removed. Now I have
+<histogram name="WinJumplist.DetailedFolderResults"
+ enum="JumplistIconsDetailedFolderOperationCategory">
<owner>chengx@chromium.org</owner>
<summary>
- This metric is recorded when folder JumpListIcons is moved (can be rename or
- copy and delete) to JumpListIconsOld. This happens when tabs are closed,
- mostly visited URLs get updated, etc. There are several key steps in this
- folder move operation. Before the move operation, there is another step that
- JumpListIconsOld folder is deleted. The status of these steps are put
- together and recorded in this metric. The failure of any of these steps is
+ This metric is recorded when folders JumpListIcons and JumpListIconsOld get
+ updated. These two folders are updated when tabs are closed, mostly visited
+ URLs get updated, etc. These two folders are updated as follows 1)
+ JumpListIconsOld with its content get deleted; 2) JumpListIcons is moved, 3)
+ if the previous step fails, JumpListIcons is deleted, 4) A new JumpListIcons
+ folder is created. The status of these 4 file operations are put together
+ and recorded in this metric. The failure of any of these file operations is
suspected to be related to a known issue.
</summary>
</histogram>
@@ -74766,8 +74767,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="WinJumplist.FolderMoveResults"
enum="JumplistIconsFolderMoveCategory">
<obsolete>
- Obselete 12/08/2016. DetailedFolderMoveResults is used for more detailed
- analysis.
+ obsolete 12/12/2016, as we are recording it anymore
</obsolete>
<owner>chengx@chromium.org</owner>
<summary>
@@ -74782,6 +74782,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</histogram>
<histogram name="WinJumplist.FolderResults" enum="JumplisticonsfolderCategory">
+ <obsolete>
+ Deprecated 12/12/2016, as we are now using WinJumplist.DetailedFolderResults
+ </obsolete>
<owner>chengx@chromium.org</owner>
<summary>
This metric is recorded when folders JumpListIcons and JumpListIconsOld get
@@ -91455,199 +91458,44 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</int>
</enum>
-<enum name="JumplistIconsDetailedFolderMoveCategory" type="int">
+<enum name="JumplistIconsDetailedFolderOperationCategory" type="int">
<int value="0"
- label="DelTargetDir Succeed - MoveFileEx Succeed - CopyFile Succeed -
- SourceDirRead Succeed - DelFile Succeed - DelSourceDir Succeed"/>
+ label="Del Dest Succeed - Mov Succeed - Del Src Succeed - Create Src
+ Succeed"/>
<int value="1"
- label="DelTargetDir Succeed - MoveFileEx Fail - CopyFile Succeed -
- SourceDirRead Succeed - DelFile Succeed - DelSourceDir Succeed"/>
+ label="Del Dest Fail - Mov Succeed - Del Src Succeed - Create Src
+ Succeed"/>
<int value="2"
- label="DelTargetDir Succeed - MoveFileEx Succeed - CopyFile Fail -
- SourceDirRead Succeed - DelFile Succeed - DelSourceDir Succeed"/>
+ label="Del Dest Succeed - Mov Fail - Del Src Succeed - Create Src
+ Succeed"/>
<int value="3"
- label="DelTargetDir Succeed - MoveFileEx Fail - CopyFile Fail -
- SourceDirRead Succeed - DelFile Succeed - DelSourceDir Succeed"/>
+ label="Del Dest Fail - Mov Fail - Del Src Succeed - Create Src Succeed"/>
<int value="4"
- label="DelTargetDir Succeed - MoveFileEx Succeed - CopyFile Succeed -
- SourceDirRead Succeed - DelFile Fail - DelSourceDir Succeed"/>
+ label="Del Dest Succeed - Mov Succeed - Del Src Fail - Create Src
+ Succeed"/>
<int value="5"
- label="DelTargetDir Succeed - MoveFileEx Fail - CopyFile Succeed -
- SourceDirRead Succeed - DelFile Fail - DelSourceDir Succeed"/>
+ label="Del Dest Fail - Mov Succeed - Del Src Fail - Create Src Succeed"/>
<int value="6"
- label="DelTargetDir Succeed - MoveFileEx Succeed - CopyFile Fail -
- SourceDirRead Succeed - DelFile Fail - DelSourceDir Succeed"/>
+ label="Del Dest Succeed - Mov Fail - Del Src Fail - Create Src Succeed"/>
<int value="7"
- label="DelTargetDir Succeed - MoveFileEx Fail - CopyFile Fail -
- SourceDirRead Succeed - DelFile Fail - DelSourceDir Succeed"/>
+ label="Del Dest Fail - Mov Fail - Del Src Fail - Create Src Succeed"/>
<int value="8"
- label="DelTargetDir Succeed - MoveFileEx Succeed - CopyFile Succeed -
- SourceDirRead Succeed - DelFile Succeed - DelSourceDir Fail"/>
+ label="Del Dest Succeed - Mov Succeed - Del Src Succeed - Create Src
+ Fail"/>
<int value="9"
- label="DelTargetDir Succeed - MoveFileEx Fail - CopyFile Succeed -
- SourceDirRead Succeed - DelFile Succeed - DelSourceDir Fail"/>
+ label="Del Dest Fail - Mov Succeed - Del Src Succeed - Create Src Fail"/>
<int value="10"
- label="DelTargetDir Succeed - MoveFileEx Succeed - CopyFile Fail -
- SourceDirRead Succeed - DelFile Succeed - DelSourceDir Fail"/>
+ label="Del Dest Succeed - Mov Fail - Del Src Succeed - Create Src Fail"/>
<int value="11"
- label="DelTargetDir Succeed - MoveFileEx Fail - CopyFile Fail -
- SourceDirRead Succeed - DelFile Succeed - DelSourceDir Fail"/>
+ label="Del Dest Fail - Mov Fail - Del Src Succeed - Create Src Fail"/>
<int value="12"
- label="DelTargetDir Succeed - MoveFileEx Succeed - CopyFile Succeed -
- SourceDirRead Succeed - DelFile Fail - DelSourceDir Fail"/>
+ label="Del Dest Succeed - Mov Succeed - Del Src Fail - Create Src Fail"/>
<int value="13"
- label="DelTargetDir Succeed - MoveFileEx Fail - CopyFile Succeed -
- SourceDirRead Succeed - DelFile Fail - DelSourceDir Fail"/>
+ label="Del Dest Fail - Mov Succeed - Del Src Fail - Create Src Fail"/>
<int value="14"
- label="DelTargetDir Succeed - MoveFileEx Succeed - CopyFile Fail -
- SourceDirRead Succeed - DelFile Fail - DelSourceDir Fail"/>
+ label="Del Dest Succeed - Mov Fail - Del Src Fail - Create Src Fail"/>
<int value="15"
- label="DelTargetDir Succeed - MoveFileEx Fail - CopyFile Fail -
- SourceDirRead Succeed - DelFile Fail - DelSourceDir Fail"/>
- <int value="16"
- label="DelTargetDir Fail - MoveFileEx Succeed - CopyFile Succeed -
- SourceDirRead Succeed - DelFile Succeed - DelSourceDir Succeed"/>
- <int value="17"
- label="DelTargetDir Fail - MoveFileEx Fail - CopyFile Succeed -
- SourceDirRead Succeed - DelFile Succeed - DelSourceDir Succeed"/>
- <int value="18"
- label="DelTargetDir Fail - MoveFileEx Succeed - CopyFile Fail -
- SourceDirRead Succeed - DelFile Succeed - DelSourceDir Succeed"/>
- <int value="19"
- label="DelTargetDir Fail - MoveFileEx Fail - CopyFile Fail -
- SourceDirRead Succeed - DelFile Succeed - DelSourceDir Succeed"/>
- <int value="20"
- label="DelTargetDir Fail - MoveFileEx Succeed - CopyFile Succeed -
- SourceDirRead Succeed - DelFile Fail - DelSourceDir Succeed"/>
- <int value="21"
- label="DelTargetDir Fail - MoveFileEx Fail - CopyFile Succeed -
- SourceDirRead Succeed - DelFile Fail - DelSourceDir Succeed"/>
- <int value="22"
- label="DelTargetDir Fail - MoveFileEx Succeed - CopyFile Fail -
- SourceDirRead Succeed - DelFile Fail - DelSourceDir Succeed"/>
- <int value="23"
- label="DelTargetDir Fail - MoveFileEx Fail - CopyFile Fail -
- SourceDirRead Succeed - DelFile Fail - DelSourceDir Succeed"/>
- <int value="24"
- label="DelTargetDir Fail - MoveFileEx Succeed - CopyFile Succeed -
- SourceDirRead Succeed - DelFile Succeed - DelSourceDir Fail"/>
- <int value="25"
- label="DelTargetDir Fail - MoveFileEx Fail - CopyFile Succeed -
- SourceDirRead Succeed - DelFile Succeed - DelSourceDir Fail"/>
- <int value="26"
- label="DelTargetDir Fail - MoveFileEx Succeed - CopyFile Fail -
- SourceDirRead Succeed - DelFile Succeed - DelSourceDir Fail"/>
- <int value="27"
- label="DelTargetDir Fail - MoveFileEx Fail - CopyFile Fail -
- SourceDirRead Succeed - DelFile Succeed - DelSourceDir Fail"/>
- <int value="28"
- label="DelTargetDir Fail - MoveFileEx Succeed - CopyFile Succeed -
- SourceDirRead Succeed - DelFile Fail - DelSourceDir Fail"/>
- <int value="29"
- label="DelTargetDir Fail - MoveFileEx Fail - CopyFile Succeed -
- SourceDirRead Succeed - DelFile Fail - DelSourceDir Fail"/>
- <int value="30"
- label="DelTargetDir Fail - MoveFileEx Succeed - CopyFile Fail -
- SourceDirRead Succeed - DelFile Fail - DelSourceDir Fail"/>
- <int value="31"
- label="DelTargetDir Fail - MoveFileEx Fail - CopyFile Fail -
- SourceDirRead Succeed - DelFile Fail - DelSourceDir Fail"/>
- <int value="32"
- label="DelTargetDir Succeed - MoveFileEx Succeed - CopyFile Succeed -
- SourceDirRead Fail - DelFile Succeed - DelSourceDir Succeed"/>
- <int value="33"
- label="DelTargetDir Succeed - MoveFileEx Fail - CopyFile Succeed -
- SourceDirRead Fail - DelFile Succeed - DelSourceDir Succeed"/>
- <int value="34"
- label="DelTargetDir Succeed - MoveFileEx Succeed - CopyFile Fail -
- SourceDirRead Fail - DelFile Succeed - DelSourceDir Succeed"/>
- <int value="35"
- label="DelTargetDir Succeed - MoveFileEx Fail - CopyFile Fail -
- SourceDirRead Fail - DelFile Succeed - DelSourceDir Succeed"/>
- <int value="36"
- label="DelTargetDir Succeed - MoveFileEx Succeed - CopyFile Succeed -
- SourceDirRead Fail - DelFile Fail - DelSourceDir Succeed"/>
- <int value="37"
- label="DelTargetDir Succeed - MoveFileEx Fail - CopyFile Succeed -
- SourceDirRead Fail - DelFile Fail - DelSourceDir Succeed"/>
- <int value="38"
- label="DelTargetDir Succeed - MoveFileEx Succeed - CopyFile Fail -
- SourceDirRead Fail - DelFile Fail - DelSourceDir Succeed"/>
- <int value="39"
- label="DelTargetDir Succeed - MoveFileEx Fail - CopyFile Fail -
- SourceDirRead Fail - DelFile Fail - DelSourceDir Succeed"/>
- <int value="40"
- label="DelTargetDir Succeed - MoveFileEx Succeed - CopyFile Succeed -
- SourceDirRead Fail - DelFile Succeed - DelSourceDir Fail"/>
- <int value="41"
- label="DelTargetDir Succeed - MoveFileEx Fail - CopyFile Succeed -
- SourceDirRead Fail - DelFile Succeed - DelSourceDir Fail"/>
- <int value="42"
- label="DelTargetDir Succeed - MoveFileEx Succeed - CopyFile Fail -
- SourceDirRead Fail - DelFile Succeed - DelSourceDir Fail"/>
- <int value="43"
- label="DelTargetDir Succeed - MoveFileEx Fail - CopyFile Fail -
- SourceDirRead Fail - DelFile Succeed - DelSourceDir Fail"/>
- <int value="44"
- label="DelTargetDir Succeed - MoveFileEx Succeed - CopyFile Succeed -
- SourceDirRead Fail - DelFile Fail - DelSourceDir Fail"/>
- <int value="45"
- label="DelTargetDir Succeed - MoveFileEx Fail - CopyFile Succeed -
- SourceDirRead Fail - DelFile Fail - DelSourceDir Fail"/>
- <int value="46"
- label="DelTargetDir Succeed - MoveFileEx Succeed - CopyFile Fail -
- SourceDirRead Fail - DelFile Fail - DelSourceDir Fail"/>
- <int value="47"
- label="DelTargetDir Succeed - MoveFileEx Fail - CopyFile Fail -
- SourceDirRead Fail - DelFile Fail - DelSourceDir Fail"/>
- <int value="48"
- label="DelTargetDir Fail - MoveFileEx Succeed - CopyFile Succeed -
- SourceDirRead Fail - DelFile Succeed - DelSourceDir Succeed"/>
- <int value="49"
- label="DelTargetDir Fail - MoveFileEx Fail - CopyFile Succeed -
- SourceDirRead Fail - DelFile Succeed - DelSourceDir Succeed"/>
- <int value="50"
- label="DelTargetDir Fail - MoveFileEx Succeed - CopyFile Fail -
- SourceDirRead Fail - DelFile Succeed - DelSourceDir Succeed"/>
- <int value="51"
- label="DelTargetDir Fail - MoveFileEx Fail - CopyFile Fail -
- SourceDirRead Fail - DelFile Succeed - DelSourceDir Succeed"/>
- <int value="52"
- label="DelTargetDir Fail - MoveFileEx Succeed - CopyFile Succeed -
- SourceDirRead Fail - DelFile Fail - DelSourceDir Succeed"/>
- <int value="53"
- label="DelTargetDir Fail - MoveFileEx Fail - CopyFile Succeed -
- SourceDirRead Fail - DelFile Fail - DelSourceDir Succeed"/>
- <int value="54"
- label="DelTargetDir Fail - MoveFileEx Succeed - CopyFile Fail -
- SourceDirRead Fail - DelFile Fail - DelSourceDir Succeed"/>
- <int value="55"
- label="DelTargetDir Fail - MoveFileEx Fail - CopyFile Fail -
- SourceDirRead Fail - DelFile Fail - DelSourceDir Succeed"/>
- <int value="56"
- label="DelTargetDir Fail - MoveFileEx Succeed - CopyFile Succeed -
- SourceDirRead Fail - DelFile Succeed - DelSourceDir Fail"/>
- <int value="57"
- label="DelTargetDir Fail - MoveFileEx Fail - CopyFile Succeed -
- SourceDirRead Fail - DelFile Succeed - DelSourceDir Fail"/>
- <int value="58"
- label="DelTargetDir Fail - MoveFileEx Succeed - CopyFile Fail -
- SourceDirRead Fail - DelFile Succeed - DelSourceDir Fail"/>
- <int value="59"
- label="DelTargetDir Fail - MoveFileEx Fail - CopyFile Fail -
- SourceDirRead Fail - DelFile Succeed - DelSourceDir Fail"/>
- <int value="60"
- label="DelTargetDir Fail - MoveFileEx Succeed - CopyFile Succeed -
- SourceDirRead Fail - DelFile Fail - DelSourceDir Fail"/>
- <int value="61"
- label="DelTargetDir Fail - MoveFileEx Fail - CopyFile Succeed -
- SourceDirRead Fail - DelFile Fail - DelSourceDir Fail"/>
- <int value="62"
- label="DelTargetDir Fail - MoveFileEx Succeed - CopyFile Fail -
- SourceDirRead Fail - DelFile Fail - DelSourceDir Fail"/>
- <int value="63"
- label="DelTargetDir Fail - MoveFileEx Fail - CopyFile Fail -
- SourceDirRead Fail - DelFile Fail - DelSourceDir Fail"/>
+ label="Del Dest Fail - Mov Fail - Del Src Fail - Create Src Fail"/>
</enum>
<enum name="JumplisticonsfolderCategory" type="int">
« no previous file with comments | « chrome/browser/win/jumplist.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698