Chromium Code Reviews Chromium Code Reviews
Issue 2570693002:
Fix base::CopyDirectory() and JumpListIcons(Old) folders' operation logic (Closed)
| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index f01549cc4f4725adacd5e1d3b19e9c97220cec33..3bea4c63dd34b88ba190bffcbd7f2aad842de736 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -74751,6 +74751,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <histogram name="WinJumplist.DetailedFolderMoveResults" |
| enum="JumplistIconsDetailedFolderMoveCategory"> |
| + <obsolete> |
| + Obsolete 12/13/2016 as we are no long recording this metric. |
| + </obsolete> |
| <owner>chengx@chromium.org</owner> |
| <summary> |
| This metric is recorded when folder JumpListIcons is moved (can be rename or |
| @@ -74763,6 +74766,21 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="WinJumplist.DetailedFolderResults" |
| + enum="JumplistIconsDetailedFolderOperationCategory"> |
| + <owner>chengx@chromium.org</owner> |
| + <summary> |
| + This metric is recorded when folders JumpListIcons and JumpListIconsOld get |
| + updated.These two folders are updated when tabs are closed, mostly visited |
| + URLs get updated, etc.These two folders are updated as follows 1) |
| + JumpListIconsOld with its content get deleted; 2) if step 1 succeeds, |
| + JumpListIcons is moved, 3) if any of the previous steps fails, JumpListIcons |
| + is deleted, 4) A new JumpListIcons folder is created.The status of these 4 |
| + file operations are put together and recorded in this metric.The failure of |
| + any of these file operations is suspected to be related to a known issue. |
|
Ilya Sherman
2016/12/13 21:08:32
Throughout this paragraph, please separate sentenc
Ilya Sherman
2016/12/13 21:08:32
Is there a bug on file for the known issue, that y
chengx
2016/12/13 23:00:40
Done. I think it is the python format script that
|
| + </summary> |
| +</histogram> |
| + |
| <histogram name="WinJumplist.FolderMoveResults" |
| enum="JumplistIconsFolderMoveCategory"> |
| <obsolete> |
| @@ -74782,6 +74800,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </histogram> |
| <histogram name="WinJumplist.FolderResults" enum="JumplisticonsfolderCategory"> |
| + <obsolete> |
|
gab
2016/12/13 21:31:22
Should matching enums be marked as obsolete? (I fo
chengx
2016/12/13 23:00:40
Done.
|
| + Deprecated 12/13/2016, as we are now recording DetailedFolderResults. |
| + </obsolete> |
| <owner>chengx@chromium.org</owner> |
| <summary> |
| This metric is recorded when folders JumpListIcons and JumpListIconsOld get |
| @@ -91650,6 +91671,46 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| SourceDirRead Fail - DelFile Fail - DelSourceDir Fail"/> |
| </enum> |
| +<enum name="JumplistIconsDetailedFolderOperationCategory" type="int"> |
| + <int value="0" |
| + label="Del Dest Succeed - Mov Succeed - Del Src Succeed - Create Src |
| + Succeed"/> |
| + <int value="1" |
| + label="Del Dest Fail - Mov Succeed - Del Src Succeed - Create Src |
| + Succeed"/> |
| + <int value="2" |
| + label="Del Dest Succeed - Mov Fail - Del Src Succeed - Create Src |
| + Succeed"/> |
| + <int value="3" |
| + label="Del Dest Fail - Mov Fail - Del Src Succeed - Create Src Succeed"/> |
| + <int value="4" |
| + label="Del Dest Succeed - Mov Succeed - Del Src Fail - Create Src |
| + Succeed"/> |
| + <int value="5" |
| + label="Del Dest Fail - Mov Succeed - Del Src Fail - Create Src Succeed"/> |
| + <int value="6" |
| + label="Del Dest Succeed - Mov Fail - Del Src Fail - Create Src Succeed"/> |
| + <int value="7" |
| + label="Del Dest Fail - Mov Fail - Del Src Fail - Create Src Succeed"/> |
| + <int value="8" |
| + label="Del Dest Succeed - Mov Succeed - Del Src Succeed - Create Src |
| + Fail"/> |
| + <int value="9" |
| + label="Del Dest Fail - Mov Succeed - Del Src Succeed - Create Src Fail"/> |
| + <int value="10" |
| + label="Del Dest Succeed - Mov Fail - Del Src Succeed - Create Src Fail"/> |
| + <int value="11" |
| + label="Del Dest Fail - Mov Fail - Del Src Succeed - Create Src Fail"/> |
| + <int value="12" |
| + label="Del Dest Succeed - Mov Succeed - Del Src Fail - Create Src Fail"/> |
| + <int value="13" |
| + label="Del Dest Fail - Mov Succeed - Del Src Fail - Create Src Fail"/> |
| + <int value="14" |
| + label="Del Dest Succeed - Mov Fail - Del Src Fail - Create Src Fail"/> |
| + <int value="15" |
| + label="Del Dest Fail - Mov Fail - Del Src Fail - Create Src Fail"/> |
| +</enum> |
| + |
| <enum name="JumplisticonsfolderCategory" type="int"> |
| <int value="0" label="Del Succeed - Mov Succeed - Create Succeed"/> |
| <int value="1" label="Del Fail - Mov Succeed - Create Succeed"/> |
