Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js

Issue 2570633004: DevTools: remove invalidateSize from Widget, make show/hideWidget receive no params. (Closed)
Patch Set: rebaselined Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js b/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js
index 3616263ac050f151e60f7213914d8f8037298465..8a3e1338830820bacb98c7a439333072bf949ff0 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js
@@ -197,7 +197,7 @@ UI.TabbedPane = class extends UI.VBox {
else
this._tabs.push(tab);
this._tabsHistory.push(tab);
- view.attach(this);
+ view.attach(this, this.element);
if (this._tabsHistory[0] === tab && this.isShowing())
this.selectTab(tab.id, userGesture);
this._updateTabElements();
@@ -420,7 +420,7 @@ UI.TabbedPane = class extends UI.VBox {
this._hideTab(tab);
tab.view.detach();
tab.view = view;
- tab.view.attach(this);
+ tab.view.attach(this, this.element);
if (isSelected)
this._showTab(tab);
if (shouldFocus)
@@ -747,7 +747,7 @@ UI.TabbedPane = class extends UI.VBox {
_showTab(tab) {
tab.tabElement.classList.add('selected');
tab.tabElement.setAttribute('aria-selected', 'true');
- tab.view.showWidget(this.element);
+ tab.view.showWidget();
this._updateTabSlider();
}

Powered by Google App Engine
This is Rietveld 408576698