DevTools: remove invalidateSize from Widget, make show/hideWidget receive no params.

third_party/WebKit/Source/devtools/front_end/ui/Widget.js

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  * Copyright (C) 2011 Google Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 240 matching lines @@
    */
   show(parentElement, insertBefore) {
     UI.Widget.__assert(parentElement, 'Attempt to attach widget with no parent element');
 
     if (!this._isRoot) {
       // Update widget hierarchy.
       var currentParent = parentElement;
       while (currentParent && !currentParent.__widget)
         currentParent = currentParent.parentElementOrShadowHost();
       UI.Widget.__assert(currentParent, 'Attempt to attach widget to orphan node');
-      this.attach(currentParent.__widget);
+      this.attach(currentParent.__widget, parentElement, insertBefore);
+    } else {
+      this._attachedToParentElement = parentElement;
+      this._attachedBeforeElement = insertBefore;
     }
 
-    this.showWidget(parentElement, insertBefore);
+    this.showWidget();
   }
 
   /**
    * @param {!UI.Widget} parentWidget
+   * @param {!Element} parentElement
+   * @param {?Element=} insertBefore
    */
-  attach(parentWidget) {
-    if (parentWidget === this._parentWidget)
+  attach(parentWidget, parentElement, insertBefore) {

[caseq, 2016/12/14 01:29:26]

Let's avoid exposing this to the public interface, it doesn't look like we ever
attach to a non-default parent or insertion point.

[pfeldman, 2016/12/14 01:38:40]

Done.

+    if (parentWidget === this._parentWidget) {
+      this._attachedToParentElement = parentElement;
+      this._attachedBeforeElement = insertBefore;

[caseq, 2016/12/14 01:29:25]

s/Element/Node?

[pfeldman, 2016/12/14 01:38:40]

Done.

+      if (this._visible)
+        this.showWidget();
       return;
+    }
     if (this._parentWidget)
       this.detach();
     this._parentWidget = parentWidget;
     this._parentWidget._children.push(this);
+    this._attachedToParentElement = parentElement;
+    this._attachedBeforeElement = insertBefore;
     this._isRoot = false;
   }
 
-  /**
-   * @param {!Element} parentElement
-   * @param {?Element=} insertBefore
-   */
-  showWidget(parentElement, insertBefore) {
+  showWidget() {
+    UI.Widget.__assert(this._parentWidget || this._isRoot, 'Attempt to show widget that has not been attached');
+    var parentElement = this._attachedToParentElement;
+    var insertBefore = this._attachedBeforeElement;

[caseq, 2016/12/14 01:29:26]

Add a check that the element is not gone?

[pfeldman, 2016/12/14 01:38:40]

Browser would throw if something like that happens.

+
     var currentParent = parentElement;
     while (currentParent && !currentParent.__widget)
       currentParent = currentParent.parentElementOrShadowHost();
 
     if (this._isRoot) {
       UI.Widget.__assert(!currentParent, 'Attempt to show root widget under another widget');
     } else {
       UI.Widget.__assert(
           currentParent && currentParent.__widget === this._parentWidget,
           'Attempt to show under node belonging to alien widget');
@@ skipping 22 matching lines @@
     if (!wasVisible && this._parentIsShowing())
       this._processWasShown();
 
     if (this._parentWidget && this._hasNonZeroConstraints())
       this._parentWidget.invalidateConstraints();
     else
       this._processOnResize();
   }
 
   hideWidget() {
-    if (!this._parentWidget)
-      return;
+    UI.Widget.__assert(this._parentWidget || this._isRoot, 'Attempt to hide widget that has not been attached');
     this._hideWidget();
   }
 
   /**
    * @param {boolean=} overrideHideOnDetach
    */
   _hideWidget(overrideHideOnDetach) {
     if (!this._visible)
       return;
     this._visible = false;
     var parentElement = this.element.parentElement;
+    this._attachedToParentElement = parentElement;
+    this._attachedBeforeElement = this.element.nextSibling;
 
     if (this._parentIsShowing())
       this._processWillHide();
 
     if (!overrideHideOnDetach && this.shouldHideOnDetach()) {
       this.element.classList.add('hidden');
     } else {
       // Force legal removal
       UI.Widget._decrementWidgetCounter(parentElement, this.element);
       UI.Widget._originalRemoveChild.call(parentElement, this.element);
@@ skipping 19 matching lines @@
       this._parentWidget._children.splice(childIndex, 1);
       if (this._parentWidget._defaultFocusedChild === this)
         this._parentWidget._defaultFocusedChild = null;
       this._parentWidget.childWasDetached(this);
       var parent = this._parentWidget;
       this._parentWidget = null;
       this._processWasDetachedFromHierarchy();
     } else {
       UI.Widget.__assert(this._isRoot, 'Removing non-root widget from DOM');
     }
+
+    this._attachedToParentElement = null;
+    this._attachedBeforeElement = null;
   }
 
   detachChildWidgets() {
     var children = this._children.slice();
     for (var i = 0; i < children.length; ++i)
       children[i].detach();
   }
 
   /**
    * @return {!Array.<!Element>}
@@ skipping 190 matching lines @@
     }
     this._invalidationsRequested = false;
     var cached = this._cachedConstraints;
     delete this._cachedConstraints;
     var actual = this.constraints();
     if (!actual.isEqual(cached) && this._parentWidget)
       this._parentWidget.invalidateConstraints();
     else
       this.doLayout();
   }
-
-  invalidateSize() {
-    if (this._parentWidget)
-      this._parentWidget.doLayout();
-  }
 };
 
 UI.Widget._originalAppendChild = Element.prototype.appendChild;
 UI.Widget._originalInsertBefore = Element.prototype.insertBefore;
 UI.Widget._originalRemoveChild = Element.prototype.removeChild;
 UI.Widget._originalRemoveChildren = Element.prototype.removeChildren;
 
 
 /**
  * @unrestricted
@@ skipping 141 matching lines @@
   UI.Widget.__assert(
       !child.__widgetCounter && !child.__widget,
       'Attempt to remove element containing widget via regular DOM operation');
   return UI.Widget._originalRemoveChild.call(this, child);
 };
 
 Element.prototype.removeChildren = function() {
   UI.Widget.__assert(!this.__widgetCounter, 'Attempt to remove element containing widget via regular DOM operation');
   UI.Widget._originalRemoveChildren.call(this);
 };