Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: tools/testing/dart/test_options.dart

Issue 2570633002: Cleanup dead compiler and runtime aliases from the test framework. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_options.dart
diff --git a/tools/testing/dart/test_options.dart b/tools/testing/dart/test_options.dart
index f84a5601688e88f58738040ff7428a7754d07570..e08f1152d8bd22eaa34c73f20039696075925df9 100644
--- a/tools/testing/dart/test_options.dart
+++ b/tools/testing/dart/test_options.dart
@@ -89,8 +89,6 @@ class TestOptionsParser {
'dart2js',
'dart2analyzer',
'app_jit',
- 'dart2app', // TODO(rmacnak): Remove after updating bots.
- 'dart2appjit', // TODO(rmacnak): Remove after updating bots.
'dartk',
'dartkp'
],
@@ -127,7 +125,6 @@ class TestOptionsParser {
[
'vm',
'dart_precompiled',
- 'dart_app', // TODO(rmacnak): Remove after updating bots.
'd8',
'jsshell',
'drt',
@@ -744,15 +741,6 @@ Note: currently only implemented for dart2js.''',
* into a list of configurations with exactly one value per key.
*/
List<Map> _expandConfigurations(Map configuration) {
- // TODO(rmacnak): Remove after updating bots.
- if (configuration['runtime'] == 'dart_app') {
- configuration['runtime'] = 'vm';
- }
- if (configuration['compiler'] == 'dart2app' ||
- configuration['compiler'] == 'dart2appjit') {
- configuration['compiler'] = 'app_jit';
- }
-
// Expand the pseudo-values such as 'all'.
if (configuration['arch'] == 'all') {
configuration['arch'] = 'ia32,x64,simarm,simarm64,simmips,simdbc64';
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698