Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5604)

Unified Diff: chromecast/browser/service/cast_service_simple.cc

Issue 2570623003: [Chromecast] Turn CastContentWindow into an abstract interface. (Closed)
Patch Set: Fix browser test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/browser/service/cast_service_simple.h ('k') | chromecast/browser/test/cast_browser_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/browser/service/cast_service_simple.cc
diff --git a/chromecast/browser/service/cast_service_simple.cc b/chromecast/browser/service/cast_service_simple.cc
index 25ebc50a4aeb0e60ebf4742f35d29699ffd7fdae..74c34f5affeff65660b553d08abe1091ec5c83a7 100644
--- a/chromecast/browser/service/cast_service_simple.cc
+++ b/chromecast/browser/service/cast_service_simple.cc
@@ -4,9 +4,11 @@
#include "chromecast/browser/service/cast_service_simple.h"
+#include <string>
+
#include "base/command_line.h"
#include "base/files/file_util.h"
-#include "chromecast/browser/cast_content_window.h"
+#include "base/memory/ptr_util.h"
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/web_contents.h"
#include "net/base/filename_util.h"
@@ -51,9 +53,9 @@ void CastServiceSimple::FinalizeInternal() {
}
void CastServiceSimple::StartInternal() {
- window_.reset(new CastContentWindow);
+ window_ = CastContentWindow::Create(this);
web_contents_ = window_->CreateWebContents(browser_context());
- window_->CreateWindowTree(web_contents_.get());
+ window_->ShowWebContents(web_contents_.get());
web_contents_->GetController().LoadURL(startup_url_, content::Referrer(),
ui::PAGE_TRANSITION_TYPED,
@@ -66,5 +68,9 @@ void CastServiceSimple::StopInternal() {
window_.reset();
}
+void CastServiceSimple::OnWindowDestroyed() {}
+
+void CastServiceSimple::OnKeyEvent(const ui::KeyEvent& key_event) {}
+
} // namespace shell
} // namespace chromecast
« no previous file with comments | « chromecast/browser/service/cast_service_simple.h ('k') | chromecast/browser/test/cast_browser_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698