[Chromecast] Turn CastContentWindow into an abstract interface.

chromecast/browser/cast_content_window_linux.h

-// Copyright 2014 The Chromium Authors. All rights reserved.
+// Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROMECAST_BROWSER_CAST_CONTENT_WINDOW_H_
-#define CHROMECAST_BROWSER_CAST_CONTENT_WINDOW_H_
+#ifndef CHROMECAST_BROWSER_CAST_CONTENT_WINDOW_LINUX_H_
+#define CHROMECAST_BROWSER_CAST_CONTENT_WINDOW_LINUX_H_
 
 #include <memory>
 
 #include "base/macros.h"
+#include "chromecast/browser/cast_content_window.h"
 #include "chromecast/graphics/cast_vsync_settings.h"
 #include "content/public/browser/web_contents_observer.h"
+#include "ui/events/keycodes/keyboard_codes.h"
 
 namespace aura {
 class WindowTreeHost;
 }
 
 namespace content {
 class BrowserContext;
 class WebContents;
 }
 
 namespace chromecast {
 namespace shell {
 
-class CastContentWindow : public content::WebContentsObserver,
-                          public CastVSyncSettings::Observer {
+class CastContentWindowLinux : public CastContentWindow,
+                               public content::WebContentsObserver,
+                               public CastVSyncSettings::Observer {

[Wez, 2017/01/11 20:47:55]

IIUC you only ever create this class via Create(), so there is no need for this
.h file - you can move the class definition into cast_content_window_linux.cc
and avoid it being publicly visible.

[derekjchow1, 2017/01/11 21:54:34]

Made constructor private, using CastContentWindow as friend class. See comment
in Android implementation file.

  public:
-  CastContentWindow();
+  CastContentWindowLinux();
 
   // Removes the window from the screen.
-  ~CastContentWindow() override;
+  ~CastContentWindowLinux() override;
 
-  // Sets the window's background to be transparent (call before
-  // CreateWindowTree).
-  void SetTransparent() { transparent_ = true; }
-
-  // Create a full-screen window for |web_contents|.
-  void CreateWindowTree(content::WebContents* web_contents);
-
+  // CastContentWindow implementation.
+  void SetTransparent() override;
+  void ShowWebContents(content::WebContents* web_contents) override;
   std::unique_ptr<content::WebContents> CreateWebContents(
-      content::BrowserContext* browser_context);
+      content::BrowserContext* browser_context) override;
 
   // content::WebContentsObserver implementation:
   void DidFirstVisuallyNonEmptyPaint() override;
+  void MediaStoppedPlaying(const MediaPlayerInfo& media_info,
+                           const MediaPlayerId& id) override;

[Wez, 2017/01/11 20:47:54]

nit: Why did you move this? It reads more naturally to see Started before
Stopped! :)

[derekjchow1, 2017/01/11 21:54:34]

Done.

   void MediaStartedPlaying(const MediaPlayerInfo& media_info,
                            const MediaPlayerId& id) override;
-  void MediaStoppedPlaying(const MediaPlayerInfo& media_info,
-                           const MediaPlayerId& id) override;
   void RenderViewCreated(content::RenderViewHost* render_view_host) override;
 
   // CastVSyncSettings::Observer implementation:
   void OnVSyncIntervalChanged(base::TimeDelta interval) override;
 
  private:
 #if defined(USE_AURA)
   std::unique_ptr<aura::WindowTreeHost> window_tree_host_;

[Wez, 2017/01/11 20:47:55]

Rather than have this class' impl become a no-op in non-Aura builds, now that
you have an abstract interface you could have Create() simply return null, and
if necessary provide a no-op fallback implementation of the API to use in that
case.

[derekjchow1, 2017/01/11 21:54:34]

We can't quite do that. Consumers of CastContentWindow also depend on the
"CreateWebContents" interface to configure the WebContents appropriate for the
platform.

[Wez, 2017/01/12 21:04:28]

Aha, I see!  Worth mention in the bug you have filed for cleaning up
createWebContents() that this file can be cleaned up at that time as well?

 #endif
   bool transparent_;
 
-  DISALLOW_COPY_AND_ASSIGN(CastContentWindow);
+  DISALLOW_COPY_AND_ASSIGN(CastContentWindowLinux);
 };
 
 }  // namespace shell
 }  // namespace chromecast
 
-#endif  // CHROMECAST_BROWSER_CAST_CONTENT_WINDOW_H_
+#endif  // CHROMECAST_BROWSER_CAST_CONTENT_WINDOW_LINUX_H_