Fix bug when packages file changes in new driver

Fix bug when packages file changes in new driver

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/223513c81abbf1434270ca2340e3e2d0f53da378

[Brian Wilkerson, 2016-12-12 18:36:01]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[Brian Wilkerson, 2016-12-12 18:36:01]

Does the file state need to be updated in some way? If so, it wasn't obvious
what or why.

[scheglov, 2016-12-12 18:42:04]

https://codereview.chromium.org/2570623002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2570623002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:556: void reanalyze(
Maybe call this "configure" and don't actually specify that it will reanalyze
everything.
We will implement it as analysis of everything, but this could be changed in the
future.

Yes, we need to reset the file state because URI resolution might be different
now, unlinked summaries are different because of different parsing options, etc.

[Brian Wilkerson, 2016-12-12 21:38:21]

ptal

[scheglov, 2016-12-12 21:48:52]

LGTM

https://codereview.chromium.org/2570623002/diff/20001/pkg/analyzer/lib/src/da...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2570623002/diff/20001/pkg/analyzer/lib/src/da...
pkg/analyzer/lib/src/dart/analysis/driver.dart:450: _sdkBundle =
sourceFactory.dartSdk.getLinkedBundle();
In theory SDK can also change, so we need to _fillSalt() here too.

[Brian Wilkerson, 2016-12-12 22:03:04]

Description was changed from

==========
Fix bug when packages file changes in new driver
==========

to

==========
Fix bug when packages file changes in new driver

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/223513c81abbf1434270ca2340e3e2d0f53da378
==========

[Brian Wilkerson, 2016-12-12 22:03:05]

Committed patchset #2 (id:20001) manually as
223513c81abbf1434270ca2340e3e2d0f53da378 (presubmit successful).