Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2570593004: Add StaticPosition to ComputeVertical/Horizontal (Closed)

Created:
4 years ago by atotic
Modified:
4 years ago
Reviewers:
cbiesinger, ikilpatrick
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add StaticPosition to ComputeVertical/Horizontal Static position part of https://codereview.chromium.org/2568743005 BUG=635619 Committed: https://crrev.com/2ac84260d9bd99d9e0f44616fbe2ad86ddbffe7e Cr-Commit-Position: refs/heads/master@{#438375}

Patch Set 1 : Add StaticPosition to ComputeVertical/Horizontal #

Total comments: 10

Patch Set 2 : CR fixes #

Total comments: 2

Patch Set 3 : cr nit #

Total comments: 4

Patch Set 4 : CR fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -65 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc View 9 chunks +35 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc View 16 chunks +78 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_units.h View 1 2 3 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
atotic
ptal
4 years ago (2016-12-13 17:31:44 UTC) #3
ikilpatrick
+christian, just some minor things :) https://codereview.chromium.org/2570593004/diff/1/third_party/WebKit/Source/core/layout/ng/ng_units.h File third_party/WebKit/Source/core/layout/ng/ng_units.h (right): https://codereview.chromium.org/2570593004/diff/1/third_party/WebKit/Source/core/layout/ng/ng_units.h#newcode309 third_party/WebKit/Source/core/layout/ng/ng_units.h:309: LayoutUnit GenericPosition(bool position_matches, ...
4 years ago (2016-12-13 18:26:53 UTC) #5
cbiesinger
looks reasonable in principle. two comments below, and I agree with Ian's comments as well. ...
4 years ago (2016-12-13 18:35:05 UTC) #6
atotic
ptal https://codereview.chromium.org/2570593004/diff/1/third_party/WebKit/Source/core/layout/ng/ng_units.h File third_party/WebKit/Source/core/layout/ng/ng_units.h (right): https://codereview.chromium.org/2570593004/diff/1/third_party/WebKit/Source/core/layout/ng/ng_units.h#newcode307 third_party/WebKit/Source/core/layout/ng/ng_units.h:307: bool IsTop() const { return type == kTopLeft ...
4 years ago (2016-12-13 19:17:20 UTC) #7
cbiesinger
looks good (except for nit below), but I'll let Ian give the final l-g-t-m https://codereview.chromium.org/2570593004/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_units.h ...
4 years ago (2016-12-13 20:11:55 UTC) #8
atotic
https://codereview.chromium.org/2570593004/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_units.h File third_party/WebKit/Source/core/layout/ng/ng_units.h (right): https://codereview.chromium.org/2570593004/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_units.h#newcode349 third_party/WebKit/Source/core/layout/ng/ng_units.h:349: else { On 2016/12/13 at 20:11:55, cbiesinger wrote: > ...
4 years ago (2016-12-13 20:26:03 UTC) #9
ikilpatrick
lgtm with nits. https://codereview.chromium.org/2570593004/diff/40001/third_party/WebKit/Source/core/layout/ng/ng_units.h File third_party/WebKit/Source/core/layout/ng/ng_units.h (right): https://codereview.chromium.org/2570593004/diff/40001/third_party/WebKit/Source/core/layout/ng/ng_units.h#newcode309 third_party/WebKit/Source/core/layout/ng/ng_units.h:309: // left/right/top distance wrt container space. ...
4 years ago (2016-12-13 20:42:36 UTC) #10
atotic
https://codereview.chromium.org/2570593004/diff/40001/third_party/WebKit/Source/core/layout/ng/ng_units.h File third_party/WebKit/Source/core/layout/ng/ng_units.h (right): https://codereview.chromium.org/2570593004/diff/40001/third_party/WebKit/Source/core/layout/ng/ng_units.h#newcode309 third_party/WebKit/Source/core/layout/ng/ng_units.h:309: // left/right/top distance wrt container space. On 2016/12/13 at ...
4 years ago (2016-12-13 20:47:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570593004/60001
4 years ago (2016-12-13 20:48:12 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/355573)
4 years ago (2016-12-13 22:23:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570593004/60001
4 years ago (2016-12-14 01:04:39 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-14 01:14:36 UTC) #21
commit-bot: I haz the power
4 years ago (2016-12-14 01:18:22 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2ac84260d9bd99d9e0f44616fbe2ad86ddbffe7e
Cr-Commit-Position: refs/heads/master@{#438375}

Powered by Google App Engine
This is Rietveld 408576698