Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 257059: Fix 10.6 problem where killall doesn't work as expected so lighttpd... (Closed)

Created:
11 years, 2 months ago by John Grabowski
Modified:
9 years, 6 months ago
Reviewers:
Mark Mentovai, TVL
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org, Nicolas Sylvain
Visibility:
Public.

Description

Fix 10.6 problem where killall doesn't work as expected so lighttpd doesn't get killed. BUG=http://crbug.com/23919 TEST=The following command lines will now work and give no errors on 10.6: python webkit/tools/layout_tests/layout_package/http_server.py --server start python webkit/tools/layout_tests/layout_package/http_server.py --server stop Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28259

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M webkit/tools/layout_tests/layout_package/platform_utils_mac.py View 1 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
John Grabowski
11 years, 2 months ago (2009-10-06 03:34:15 UTC) #1
TVL
lg or use the suggested change. http://codereview.chromium.org/257059/diff/1/2 File webkit/tools/layout_tests/layout_package/platform_utils_mac.py (right): http://codereview.chromium.org/257059/diff/1/2#newcode109 Line 109: subprocess.call(['killall', '-u', ...
11 years, 2 months ago (2009-10-06 11:51:33 UTC) #2
John Grabowski
On 2009/10/06 11:51:33, TVL wrote: > lg or use the suggested change. > > http://codereview.chromium.org/257059/diff/1/2 ...
11 years, 2 months ago (2009-10-07 16:36:47 UTC) #3
Mark Mentovai
11 years, 2 months ago (2009-10-07 16:39:14 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698