Issue 2570583002: Added conversion from thread id to intptr that fixes breaking build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2570583002: Added conversion from thread id to intptr that fixes breaking build. (Closed)

Created:
4 years ago by bkonyi

Modified:
4 years ago

Reviewers:
zra, Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Added conversion from thread id to intptr that fixes breaking build. BUG= R=johnmccutchan@google.com, zra@google.com Committed: https://github.com/dart-lang/sdk/commit/d217b21ca6c44bb7cd75027c6b0c30b4f83a5435

Patch Set 1 #

Total comments: 1

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	runtime/vm/thread.cc	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

bkonyi

Committed patchset #1 (id:1) manually as d217b21ca6c44bb7cd75027c6b0c30b4f83a5435 (presubmit successful).

4 years ago (2016-12-12 18:13:51 UTC) #6

zra

4 years ago (2016-12-12 18:20:53 UTC) #7

Message was sent while issue was closed.

https://codereview.chromium.org/2570583002/diff/1/runtime/vm/thread.cc
File runtime/vm/thread.cc (right):

https://codereview.chromium.org/2570583002/diff/1/runtime/vm/thread.cc#newcod...
runtime/vm/thread.cc:215: ThreadIdToIntPtr(os_thread()->trace_id()));
Sorry, I should have noticed that it looks like this needs to be
OSThread::ThreadIdToIntPtr().

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages