Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: device/vr/android/gvr/gvr_delegate.h

Issue 2570553004: Clean up some VrShell threading issues and remove unnecessary WeakPtr types. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/vr/android/gvr/gvr_delegate.h
diff --git a/device/vr/android/gvr/gvr_delegate.h b/device/vr/android/gvr/gvr_delegate.h
index 4083c69aac6e42b50b97a0d09975b5e384103101..284709508c971bf474227478cd767f3c371487b6 100644
--- a/device/vr/android/gvr/gvr_delegate.h
+++ b/device/vr/android/gvr/gvr_delegate.h
@@ -5,7 +5,6 @@
#ifndef DEVICE_VR_ANDROID_GVR_DELEGATE_H
#define DEVICE_VR_ANDROID_GVR_DELEGATE_H
-#include "base/memory/weak_ptr.h"
#include "device/vr/android/gvr/gvr_device_provider.h"
#include "device/vr/vr_export.h"
#include "third_party/gvr-android-sdk/src/ndk/include/vr/gvr/capi/include/gvr_types.h"
@@ -37,12 +36,11 @@ class DEVICE_VR_EXPORT GvrDelegateProvider {
static void SetInstance(GvrDelegateProvider* delegate_provider);
static GvrDelegateProvider* GetInstance();
- virtual void SetDeviceProvider(
- base::WeakPtr<GvrDeviceProvider> device_provider) = 0;
+ virtual void SetDeviceProvider(GvrDeviceProvider* device_provider) = 0;
virtual void RequestWebVRPresent(
const base::Callback<void(bool)>& callback) = 0;
virtual void ExitWebVRPresent() = 0;
- virtual base::WeakPtr<GvrDelegate> GetNonPresentingDelegate() = 0;
+ virtual GvrDelegate* GetNonPresentingDelegate() = 0;
virtual void DestroyNonPresentingDelegate() = 0;
virtual void SetListeningForActivate(bool listening) = 0;

Powered by Google App Engine
This is Rietveld 408576698