Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

Issue 2570553003: DevTools: Hide overview pane on timeline landing page. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 710 matching lines...) Expand 10 before | Expand all | Expand 10 after
721 return; 721 return;
722 } 722 }
723 if (this._helpMessageElement) 723 if (this._helpMessageElement)
724 this._helpMessageElement.remove(); 724 this._helpMessageElement.remove();
725 delete this._helpMessageElement; 725 delete this._helpMessageElement;
726 } 726 }
727 727
728 _showLandingPage() { 728 _showLandingPage() {
729 if (this._landingPage) 729 if (this._landingPage)
730 return; 730 return;
731 this._detailsSplitWidget.detach(); 731 this._timelinePane.detach();
732 this._landingPage = new Timeline.TimelineLandingPage(); 732 this._landingPage = new Timeline.TimelineLandingPage();
733 this._landingPage.show(this._timelinePane.element); 733 this._landingPage.show(this.element);
734 } 734 }
735 735
736 _hideLandingPage() { 736 _hideLandingPage() {
737 if (!this._landingPage) 737 if (!this._landingPage)
738 return; 738 return;
739 this._landingPage.detach(); 739 this._landingPage.detach();
740 this._landingPage = null; 740 this._landingPage = null;
741 this._detailsSplitWidget.show(this._timelinePane.element); 741 this._timelinePane.show(this.element);
742 } 742 }
743 743
744 /** 744 /**
745 * @override 745 * @override
746 */ 746 */
747 loadingStarted() { 747 loadingStarted() {
748 this._hideRecordingHelpMessage(); 748 this._hideRecordingHelpMessage();
749 749
750 if (this._statusPane) 750 if (this._statusPane)
751 this._statusPane.hide(); 751 this._statusPane.hide();
(...skipping 1218 matching lines...) Expand 10 before | Expand all | Expand 10 after
1970 } 1970 }
1971 1971
1972 /** 1972 /**
1973 * @override 1973 * @override
1974 * @param {!SDK.Target} target 1974 * @param {!SDK.Target} target
1975 */ 1975 */
1976 targetRemoved(target) { 1976 targetRemoved(target) {
1977 this._targets.remove(target, true); 1977 this._targets.remove(target, true);
1978 } 1978 }
1979 }; 1979 };
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698