Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2570513003: This change removes HpackEncoder::EncodeHeaderSetWithoutCompression() and the corresponding progres… (Closed)

Created:
4 years ago by Biren Roy
Modified:
4 years ago
Reviewers:
Bence
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This change removes HpackEncoder::EncodeHeaderSetWithoutCompression() and the corresponding progressive encoding method parameter. This change only affects code paths exercised in tests. This CL lands server change 141469300 by birenroy. BUG=488484 Committed: https://crrev.com/980e98848b8b005af82e0d7ed6c096162d8c31a8 Cr-Commit-Position: refs/heads/master@{#438028}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -117 lines) Patch
M net/spdy/hpack/hpack_encoder.h View 4 chunks +4 lines, -9 lines 0 comments Download
M net/spdy/hpack/hpack_encoder.cc View 9 chunks +25 lines, -43 lines 0 comments Download
M net/spdy/hpack/hpack_encoder_test.cc View 9 chunks +37 lines, -48 lines 0 comments Download
M net/spdy/spdy_framer.cc View 4 chunks +8 lines, -15 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Biren Roy
4 years ago (2016-12-12 17:59:35 UTC) #2
Bence
LGTM.
4 years ago (2016-12-12 18:05:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570513003/1
4 years ago (2016-12-13 02:41:29 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-13 03:35:17 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/980e98848b8b005af82e0d7ed6c096162d8c31a8
Cr-Commit-Position: refs/heads/master@{#438028}

Powered by Google App Engine
This is Rietveld 408576698