Issue 25705004: content: Move MockWebClipboardImpl into content namespace.

Issue 25705004: content: Move MockWebClipboardImpl into content namespace. (Closed)

Created:
7 years, 2 months ago by tfarina

Modified:
7 years, 2 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dcheng, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

content: Move MockWebClipboardImpl into content namespace. This is a follow up to r226477 as requested by jam in https://codereview.chromium.org/25378002/#msg17. BUG=265753 R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227183

Patch Set 3 : mv TestWebKitPlatformSupport too #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -33 lines)			Patch
M	content/shell/renderer/shell_content_renderer_client.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	content/test/mock_webclipboard_impl.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/test/mock_webclipboard_impl.cc	View	1	7 chunks	+18 lines, -12 lines	0 comments	Download
M	content/test/test_webkit_platform_support.h	View	1 2	2 chunks	+7 lines, -3 lines	0 comments	Download
M	content/test/test_webkit_platform_support.cc	View	1 2	6 chunks	+9 lines, -7 lines	0 comments	Download
M	content/test/webkit_support.h	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/test/webkit_support.cc	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/test/webkit_unit_test_support.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	content/test/webkit_unit_test_support.cc	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm https://codereview.chromium.org/25705004/diff/5001/content/test/test_webkit_platform_support.h File content/test/test_webkit_platform_support.h (right): https://codereview.chromium.org/25705004/diff/5001/content/test/test_webkit_platform_support.h#newcode23 content/test/test_webkit_platform_support.h:23: class TestWebKitPlatformSupport nit: this file should be in ...

7 years, 2 months ago (2013-10-03 17:04:17 UTC) #2

tfarina

https://codereview.chromium.org/25705004/diff/5001/content/test/test_webkit_platform_support.h File content/test/test_webkit_platform_support.h (right): https://codereview.chromium.org/25705004/diff/5001/content/test/test_webkit_platform_support.h#newcode23 content/test/test_webkit_platform_support.h:23: class TestWebKitPlatformSupport On 2013/10/03 17:04:18, jam wrote: > nit: ...

7 years, 2 months ago (2013-10-04 23:29:47 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/25705004/13001

7 years, 2 months ago (2013-10-04 23:30:01 UTC) #4

Message was sent while issue was closed.

Change committed as 227183

Expand Messages | Collapse Messages