Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3948)

Unified Diff: build/config/compiler/compiler.gni

Issue 2570483004: Add support for link repros and use it on net_perftests. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/toolchain/win/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/compiler.gni
diff --git a/build/config/compiler/compiler.gni b/build/config/compiler/compiler.gni
index df12be920b53319190d9b60bb0994165e2000d43..656716885587df086a92eebdefd3613a09e9e04e 100644
--- a/build/config/compiler/compiler.gni
+++ b/build/config/compiler/compiler.gni
@@ -44,6 +44,18 @@ declare_args() {
# Whether or not we should turn on incremental WPO. Only affects the VS
# Windows build.
use_incremental_wpo = false
+
+ # Root directory the will store the MSVC link repro. This should only be used
scottmg 2016/12/13 00:03:23 "the will store" -> "that will store" (?)
Sébastien Marchand 2016/12/13 00:14:26 Done.
+ # for debugging purposes on the builders where a MSVC linker flakyness has
+ # been observed. The targets for which a link repro should be generated
+ # should add somethink like this to their configuration:
scottmg 2016/12/13 00:03:23 somethink -> something
Sébastien Marchand 2016/12/13 00:14:26 Ark, 2 typos in 5 lines, sorry for that.
+ # if (linkrepro_root_dir != "") {
+ # ldflags = ["/LINKREPRO:" + linkrepro_root_dir + "/" + target_name]
+ # }
+ #
+ # Note that doing a link repro uses a lot of disk space and slow down the
scottmg 2016/12/13 00:03:23 slow -> slows
Sébastien Marchand 2016/12/13 00:14:26 Done.
+ # build, so this shouldn't be enabled on too many targets.
scottmg 2016/12/13 00:03:23 Add a crbug link here.
Sébastien Marchand 2016/12/13 00:14:26 Done.
+ linkrepro_root_dir = ""
}
declare_args() {
« no previous file with comments | « no previous file | build/toolchain/win/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698