Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Side by Side Diff: build/config/compiler/compiler.gni

Issue 2570483004: Add support for link repros and use it on net_perftests. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/toolchain/win/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/compiler/pgo/pgo.gni") 8 import("//build/config/compiler/pgo/pgo.gni")
9 import("//build/config/sanitizers/sanitizers.gni") 9 import("//build/config/sanitizers/sanitizers.gni")
10 import("//build/toolchain/goma.gni") 10 import("//build/toolchain/goma.gni")
(...skipping 26 matching lines...) Expand all
37 use_debug_fission = "default" 37 use_debug_fission = "default"
38 38
39 # Tell VS to create a PDB that references information in .obj files rather 39 # Tell VS to create a PDB that references information in .obj files rather
40 # than copying it all. This should improve linker performance. mspdbcmf.exe 40 # than copying it all. This should improve linker performance. mspdbcmf.exe
41 # can be used to convert a fastlink pdb to a normal one. 41 # can be used to convert a fastlink pdb to a normal one.
42 is_win_fastlink = false 42 is_win_fastlink = false
43 43
44 # Whether or not we should turn on incremental WPO. Only affects the VS 44 # Whether or not we should turn on incremental WPO. Only affects the VS
45 # Windows build. 45 # Windows build.
46 use_incremental_wpo = false 46 use_incremental_wpo = false
47
48 # Root directory the will store the MSVC link repro. This should only be used
scottmg 2016/12/13 00:03:23 "the will store" -> "that will store" (?)
Sébastien Marchand 2016/12/13 00:14:26 Done.
49 # for debugging purposes on the builders where a MSVC linker flakyness has
50 # been observed. The targets for which a link repro should be generated
51 # should add somethink like this to their configuration:
scottmg 2016/12/13 00:03:23 somethink -> something
Sébastien Marchand 2016/12/13 00:14:26 Ark, 2 typos in 5 lines, sorry for that.
52 # if (linkrepro_root_dir != "") {
53 # ldflags = ["/LINKREPRO:" + linkrepro_root_dir + "/" + target_name]
54 # }
55 #
56 # Note that doing a link repro uses a lot of disk space and slow down the
scottmg 2016/12/13 00:03:23 slow -> slows
Sébastien Marchand 2016/12/13 00:14:26 Done.
57 # build, so this shouldn't be enabled on too many targets.
scottmg 2016/12/13 00:03:23 Add a crbug link here.
Sébastien Marchand 2016/12/13 00:14:26 Done.
58 linkrepro_root_dir = ""
47 } 59 }
48 60
49 declare_args() { 61 declare_args() {
50 # Whether or not the official builds should be built with full WPO. Enabled by 62 # Whether or not the official builds should be built with full WPO. Enabled by
51 # default for the PGO and the x64 builds. 63 # default for the PGO and the x64 builds.
52 if (chrome_pgo_phase > 0) { 64 if (chrome_pgo_phase > 0) {
53 full_wpo_on_official = true 65 full_wpo_on_official = true
54 } else { 66 } else {
55 full_wpo_on_official = false 67 full_wpo_on_official = false
56 } 68 }
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 } 111 }
100 112
101 # Assert that the configuration isn't going to hit https://crbug.com/648948. 113 # Assert that the configuration isn't going to hit https://crbug.com/648948.
102 assert(ignore_elf32_limitations || !is_android || 114 assert(ignore_elf32_limitations || !is_android ||
103 (android_64bit_target_cpu && !build_apk_secondary_abi) || 115 (android_64bit_target_cpu && !build_apk_secondary_abi) ||
104 is_component_build || symbol_level < 2 || is_clang, 116 is_component_build || symbol_level < 2 || is_clang,
105 "Android 32-bit non-component, non-clang builds cannot have " + 117 "Android 32-bit non-component, non-clang builds cannot have " +
106 "symbol_level=2 due to 4GiB file size limit, see " + 118 "symbol_level=2 due to 4GiB file size limit, see " +
107 "https://crbug.com/648948. If you really want to try this out, " + 119 "https://crbug.com/648948. If you really want to try this out, " +
108 "set ignore_elf32_limitations=true.") 120 "set ignore_elf32_limitations=true.")
OLDNEW
« no previous file with comments | « no previous file | build/toolchain/win/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698