Issue 2570483003: Cleanup the kernel service implementation and avoid printing on the console when no tracing flags a…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2570483003: Cleanup the kernel service implementation and avoid printing on the console when no tracing flags a… (Closed)

Created:
4 years ago by kasperl

Modified:
4 years ago

Reviewers:
Kevin Millikin (Google), hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Cleanup the kernel service implementation and avoid printing on the console when no tracing flags are provided. R=kmillikin@google.com, hausner@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/53dd819a4c9817530dd8f04e422f50fb8b3bd28e

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -91 lines)			Patch
	M	runtime/bin/main.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	runtime/tools/kernel-service.dart	View		2 chunks	+39 lines, -90 lines	0 comments	Download

Total messages: 5 (1 generated)

kasperl

4 years ago (2016-12-13 08:08:18 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
53dd819a4c9817530dd8f04e422f50fb8b3bd28e (presubmit successful).