Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1609)

Issue 257045: Linux: implement ShouldRenderRichAnimation() based on $DISPLAY.

Created:
11 years, 2 months ago by Mike Mammarella
Modified:
11 years, 2 months ago
Reviewers:
agl, dank
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Linux: implement ShouldRenderRichAnimation() based on $DISPLAY. Local display names start with a colon; remote ones don't. BUG=none TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M app/animation.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mike Mammarella
11 years, 2 months ago (2009-10-03 00:16:33 UTC) #1
Evan Stade
I am not the right reviewer. Try: agl, dank, evan maybe. But I wonder whether ...
11 years, 2 months ago (2009-10-03 00:38:42 UTC) #2
dank
Seems plausible. It might be nice to have a way to override this for people ...
11 years, 2 months ago (2009-10-03 00:45:22 UTC) #3
Mike Mammarella
11 years, 2 months ago (2009-10-03 00:47:53 UTC) #4
On 2009/10/03 00:45:22, dank wrote:
> Seems plausible.  
> It might be nice to have a way to override this for people with
> really fast networks (or who want to pummel their systems)?
> 
> Alternately I suppose we might check for the X shared memory extension.

I was just going to point out this thread where checking for that is suggested:
http://www.mail-archive.com/gtk-devel-list@gnome.org/msg06432.html

That's a larger patch and I'll leave doing that to somebody else if we want to
do it that way.

Powered by Google App Engine
This is Rietveld 408576698