Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

Issue 2570423003: Remove paintOffsetTranslation for fixed-position elements. (Closed)
Patch Set: none Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
index 6baebf02bfb5a7794626ffa4a5af5af5d5137593..2d690fffb9312fb6eb130621d9cebad02808d9f2 100644
--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
@@ -219,13 +219,8 @@ void PaintPropertyTreeBuilder::updatePaintOffsetTranslation(
usesPaintOffsetTranslation = true;
} else if (object.isBoxModelObject() &&
context.current.paintOffset != LayoutPoint()) {
- // TODO(trchen): Eliminate PaintLayer dependency.
- // TODO(chrishtr): When changing the condition here, make sure to update
- // the condition in LayoutBoxModelObject::styleDidChange() above
- // setNeedsPaintPropertyUpdate().
PaintLayer* layer = toLayoutBoxModelObject(object).layer();
- if (layer &&
- layer->paintsWithTransform(GlobalPaintFlattenCompositingLayers))
+ if (layer && layer->paintsWithTransform(GlobalPaintNormalPhase))
usesPaintOffsetTranslation = true;
}

Powered by Google App Engine
This is Rietveld 408576698