Make try/catch/finally work with Kernel code and some refactoring.

Make try/catch/finally work with Kernel code and some refactoring.

BUG=https://github.com/dart-lang/sdk/issues/27394
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/9b003dd2f91eed2b56229bc3b22730ebf5d2b3c9

[Emily Fortuna, 2016-12-14 23:11:03]

efortuna@google.com changed reviewers:
+ het@google.com, sigmund@google.com

[Emily Fortuna, 2016-12-14 23:11:03]

I had a bigger change updating buildIsNode to not use element, but that ended up
being more complicated, so that will be coming in a follow up change.

[Emily Fortuna, 2016-12-14 23:12:02]

Oh, also, I'm burying the lede: this brings our overall test pass rate up to
70.9%!!!!

[Siggi Cherem (dart-lang), 2016-12-15 00:59:46]

very exciting!

I honestly only have very minor nit picks, lgtm!

https://codereview.chromium.org/2570273004/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2570273004/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:1906: HInstruction buildIsNode(
nit: consider moving this up next to visitIsExpression just to keep history of
changes easier to track if we need to :)

https://codereview.chromium.org/2570273004/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:2133: // checked?
correct - I don't believe there is a way to specify a type for it.

I mean the `catch (e, s)` part in :

  try {
  } on Foo catch (e, s) {
  ...
  }

only accepts a variable name, but no type.

https://codereview.chromium.org/2570273004/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/kernel/try_catch_test.dart (right):

https://codereview.chromium.org/2570273004/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/kernel/try_catch_test.dart:75: // This is the same test
as above, but by enabling type inference
delete comment? (maybe unrelated from before?)_

https://codereview.chromium.org/2570273004/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/kernel/try_catch_test.dart:78: return check(code,
disableTypeInference: false);
remove the disabling flag too? (below as well?)

[Emily Fortuna, 2016-12-15 01:25:43]

https://codereview.chromium.org/2570273004/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2570273004/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:1906: HInstruction buildIsNode(
On 2016/12/15 00:59:45, Siggi Cherem (dart-lang) wrote:
> nit: consider moving this up next to visitIsExpression just to keep history of
> changes easier to track if we need to :)

Done.

https://codereview.chromium.org/2570273004/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:2133: // checked?
On 2016/12/15 00:59:45, Siggi Cherem (dart-lang) wrote:
> correct - I don't believe there is a way to specify a type for it.
> 
> I mean the `catch (e, s)` part in :
> 
>   try {
>   } on Foo catch (e, s) {
>   ...
>   }
> 
> only accepts a variable name, but no type.

Acknowledged.

https://codereview.chromium.org/2570273004/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/kernel/try_catch_test.dart (right):

https://codereview.chromium.org/2570273004/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/kernel/try_catch_test.dart:75: // This is the same test
as above, but by enabling type inference
On 2016/12/15 00:59:45, Siggi Cherem (dart-lang) wrote:
> delete comment? (maybe unrelated from before?)_

oh yeah. oops. I've been found-out for copying test outlines!

https://codereview.chromium.org/2570273004/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/kernel/try_catch_test.dart:78: return check(code,
disableTypeInference: false);
On 2016/12/15 00:59:45, Siggi Cherem (dart-lang) wrote:
> remove the disabling flag too? (below as well?)

Done.

[Emily Fortuna, 2016-12-15 17:08:20]

Description was changed from

==========
Make try/catch/finally work with Kernel code and some refactoring.

BUG=https://github.com/dart-lang/sdk/issues/27394
==========

to

==========
Make try/catch/finally work with Kernel code and some refactoring.

BUG=https://github.com/dart-lang/sdk/issues/27394
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9b003dd2f91eed2b56229bc3b22730ebf5d2b3c9
==========

[Emily Fortuna, 2016-12-15 17:08:21]

Committed patchset #3 (id:40001) manually as
9b003dd2f91eed2b56229bc3b22730ebf5d2b3c9 (presubmit successful).