third_party/WebKit/LayoutTests/inspector/sources/debugger/extract-javascript-identifiers.html - Issue 2570263002: DevTools: introduce API for the Common.FormatterWorkerPool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger/extract-javascript-identifiers.html

Issue 2570263002: DevTools: introduce API for the Common.FormatterWorkerPool. (Closed)

Patch Set: address comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/network/network-json-parser.html ('k') | third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger/extract-javascript-identifiers.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger/extract-javascript-identifiers.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger/extract-javascript-identifiers.html

index 45728a7ec1fa9192b297975ce8ab346fc221bce9..e110c67fc3d4231d4a1b7e2461dc0366e0480c92 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger/extract-javascript-identifiers.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger/extract-javascript-identifiers.html

@@ -56,14 +56,13 @@ function test()

{

InspectorTest.addResult("Text:");

InspectorTest.addResult(" " + text + "\n");

- Common.formatterWorkerPool.runTask("javaScriptIdentifiers", {content: text})

+ Common.formatterWorkerPool.javaScriptIdentifiers(text)

.then(onIdentifiers)

.then(next);

}

- function onIdentifiers(event)

+ function onIdentifiers(ids)

{

- var ids = event ? event.data : [];

InspectorTest.addResult("Identifiers:");

for (var id of ids)

InspectorTest.addResult(` id: ${id.name} offset: ${id.offset}`);