Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1623)

Unified Diff: chrome/browser/ui/webui/browsing_history_handler.cc

Issue 2570253002: [MD History] Fix toolbar dates in grouped mode. (Closed)
Patch Set: use date interval format Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/browsing_history_handler.cc
diff --git a/chrome/browser/ui/webui/browsing_history_handler.cc b/chrome/browser/ui/webui/browsing_history_handler.cc
index 5e5b24e536920837758cb6854f2350dc105465f2..2edff4482eb0515a5e32c80c7f1cf05bc9f1cb7f 100644
--- a/chrome/browser/ui/webui/browsing_history_handler.cc
+++ b/chrome/browser/ui/webui/browsing_history_handler.cc
@@ -14,7 +14,6 @@
#include "base/i18n/rtl.h"
#include "base/i18n/time_formatting.h"
#include "base/logging.h"
-#include "base/memory/ptr_util.h"
#include "base/strings/string16.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/utf_string_conversions.h"
@@ -525,6 +524,14 @@ void BrowsingHistoryHandler::OnQueryComplete(
"queryEndTime",
GetRelativeDateLocalized(clock_.get(), query_results_info->end_time));
+ results_info.SetString(
+ "queryStartMonth",
+ TimeFormatMonthAndYear(query_results_info->start_time));
+ results_info.SetString(
+ "queryInterval", DateIntervalFormat(query_results_info->start_time,
+ query_results_info->end_time,
+ base::DATE_FORMAT_MONTH_WEEKDAY_DAY));
jungshik at Google 2017/01/10 01:12:29 Don't you 'base::' for DateIntervalFormat... and T
calamity 2017/01/16 02:49:25 Huh. surprisingly this worked without it. Probably
+
web_ui()->CallJavascriptFunctionUnsafe("historyResult", results_info,
results_value);
}

Powered by Google App Engine
This is Rietveld 408576698