Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 257023002: Adds back some debugging code (Closed)

Created:
6 years, 7 months ago by sky
Modified:
6 years, 7 months ago
Reviewers:
flackr
CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank
Visibility:
Public.

Description

Adds back some debugging code We're getting another crash that looks like an observer is being destroyed before removing itself. BUG=365364 TEST=none R=flackr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266681

Patch Set 1 #

Patch Set 2 : update bug #

Patch Set 3 : another ref #

Total comments: 4

Patch Set 4 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -2 lines) Patch
M ui/aura/aura.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/window.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/aura/window_observer.h View 1 2 3 2 chunks +18 lines, -1 line 0 comments Download
A ui/aura/window_observer.cc View 1 2 3 1 chunk +31 lines, -0 lines 0 comments Download
M ui/aura/window_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
sky
This is a variation of debugging code you added a while back.
6 years, 7 months ago (2014-04-28 16:49:55 UTC) #1
flackr
LGTM with nit. https://codereview.chromium.org/257023002/diff/40001/ui/aura/window_observer.h File ui/aura/window_observer.h (right): https://codereview.chromium.org/257023002/diff/40001/ui/aura/window_observer.h#newcode130 ui/aura/window_observer.h:130: }; This now need DISALLOW_COPY_AND_ASSIGN I ...
6 years, 7 months ago (2014-04-28 17:08:27 UTC) #2
flackr
https://codereview.chromium.org/257023002/diff/40001/ui/aura/window_observer.cc File ui/aura/window_observer.cc (right): https://codereview.chromium.org/257023002/diff/40001/ui/aura/window_observer.cc#newcode7 ui/aura/window_observer.cc:7: #include "base/debug/stack_trace.h" This doesn't seem to be used.
6 years, 7 months ago (2014-04-28 17:11:42 UTC) #3
sky
https://codereview.chromium.org/257023002/diff/40001/ui/aura/window_observer.cc File ui/aura/window_observer.cc (right): https://codereview.chromium.org/257023002/diff/40001/ui/aura/window_observer.cc#newcode7 ui/aura/window_observer.cc:7: #include "base/debug/stack_trace.h" On 2014/04/28 17:11:42, flackr wrote: > This ...
6 years, 7 months ago (2014-04-28 17:18:35 UTC) #4
sky
The CQ bit was checked by sky@chromium.org
6 years, 7 months ago (2014-04-28 17:18:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/257023002/60001
6 years, 7 months ago (2014-04-28 17:19:12 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 17:51:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on android_aosp
6 years, 7 months ago (2014-04-28 17:51:19 UTC) #8
sky
The CQ bit was checked by sky@chromium.org
6 years, 7 months ago (2014-04-28 21:17:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/257023002/60001
6 years, 7 months ago (2014-04-28 21:20:03 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 22:15:35 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 7 months ago (2014-04-28 22:15:35 UTC) #12
sky
Committed patchset #4 manually as r266681 (presubmit successful).
6 years, 7 months ago (2014-04-28 22:41:10 UTC) #13
robliao
6 years, 7 months ago (2014-04-28 23:41:06 UTC) #14
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/252963003/ by robliao@chromium.org.

The reason for reverting is: Breaks ash_unittests FullscreenWindow 

VideoDetectorTest.FullscreenWindow (run #1):
[ RUN      ] VideoDetectorTest.FullscreenWindow
[21122:21122:0428/162209:675210655:WARNING:cras_audio_handler.cc(472)] Audio
input allowed by policy, sets input id=0x0 mute=false
[21122:21122:0428/162209:675210697:WARNING:cras_audio_handler.cc(508)]
SetInputMuteInternal sets active input device id=0x0 mute=0
[21122:21122:0428/162209:675210737:WARNING:cras_audio_handler.cc(429)]
SetupAudioInputState for active device id=0x2715 mute=0
[21122:21122:0428/162209:675210757:WARNING:cras_audio_handler.cc(508)]
SetInputMuteInternal sets active input device id=0x2715 mute=0
Xlib:  extension "RANDR" missing on display ":9".
Xlib:  extension "RANDR" missing on display ":9".
[21122:21122:0428/162209:675250984:FATAL:window_observer.cc(18)] Check failed: 0
== observing_ (0 vs. 1).

Powered by Google App Engine
This is Rietveld 408576698