third_party/WebKit/Source/core/layout/LayoutObject.h - Issue 2570223002: [SPv2] Associate effect property nodes for SVG paint chunks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.h

Issue 2570223002: [SPv2] Associate effect property nodes for SVG paint chunks (Closed)

Patch Set: fix isolation & apply effects to SVG graphics elements Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutObject.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.h b/third_party/WebKit/Source/core/layout/LayoutObject.h

index 5757694cf4caa5d19d02c67548108868b68b706a..175c2efb25c6ebe4ea0e69932db0ab40dbd1a3d1 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObject.h

+++ b/third_party/WebKit/Source/core/layout/LayoutObject.h

@@ -649,7 +649,11 @@ class CORE_EXPORT LayoutObject : public ImageResourceObserver,

return !isSVG() || (isSVGContainer() && !isSVGHiddenContainer()) ||

isSVGShape() || isSVGImage() || isSVGText();

}

- virtual bool hasNonIsolatedBlendingDescendants() const { return false; }

+ virtual bool hasNonIsolatedBlendingDescendants() const {

+ // SVG only. For non-SVG objects, query PaintLayer instead.

+ NOTREACHED();

+ return false;

+ }

enum DescendantIsolationState {

DescendantIsolationRequired,

DescendantIsolationNeedsUpdate,