Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.h

Issue 2570223002: [SPv2] Associate effect property nodes for SVG paint chunks (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutObject.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.h b/third_party/WebKit/Source/core/layout/LayoutObject.h
index 467bf0a4bba259a9c091936a4b7708924da44523..7541a82e21c39478c2b6bad1bc5c2a294696f45f 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObject.h
+++ b/third_party/WebKit/Source/core/layout/LayoutObject.h
@@ -648,7 +648,11 @@ class CORE_EXPORT LayoutObject : public ImageResourceObserver,
return !isSVG() || (isSVGContainer() && !isSVGHiddenContainer()) ||
isSVGShape() || isSVGImage() || isSVGText();
}
- virtual bool hasNonIsolatedBlendingDescendants() const { return false; }
+ virtual bool hasNonIsolatedBlendingDescendants() const {
trchen 2016/12/14 01:36:55 Why not just remove the thing and make it part of
+ // SVG only. For non-SVG objects, query PaintLayer instead.
+ NOTREACHED();
+ return false;
+ }
enum DescendantIsolationState {
DescendantIsolationRequired,
DescendantIsolationNeedsUpdate,

Powered by Google App Engine
This is Rietveld 408576698