Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Side by Side Diff: src/compiler/code-assembler.cc

Issue 2570213002: [stubs] Enable machine graph verification for CodeStubAssembler and friends by default in debug mode (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-assembler.h" 5 #include "src/compiler/code-assembler.h"
6 6
7 #include <ostream> 7 #include <ostream>
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/compiler/graph.h" 10 #include "src/compiler/graph.h"
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 63
64 CodeAssemblerState::~CodeAssemblerState() {} 64 CodeAssemblerState::~CodeAssemblerState() {}
65 65
66 CodeAssembler::~CodeAssembler() {} 66 CodeAssembler::~CodeAssembler() {}
67 67
68 void CodeAssembler::CallPrologue() {} 68 void CodeAssembler::CallPrologue() {}
69 69
70 void CodeAssembler::CallEpilogue() {} 70 void CodeAssembler::CallEpilogue() {}
71 71
72 // static 72 // static
73 Handle<Code> CodeAssembler::GenerateCode(CodeAssemblerState* state, 73 Handle<Code> CodeAssembler::GenerateCode(CodeAssemblerState* state) {
74 bool verify_graph) {
75 // TODO(ishell): Remove verify_graph parameter and always enable the
76 // verification once all the issues are fixed.
77 DCHECK(!state->code_generated_); 74 DCHECK(!state->code_generated_);
78 75
79 RawMachineAssembler* rasm = state->raw_assembler_.get(); 76 RawMachineAssembler* rasm = state->raw_assembler_.get();
80 Schedule* schedule = rasm->Export(); 77 Schedule* schedule = rasm->Export();
81 Handle<Code> code = Pipeline::GenerateCodeForCodeStub( 78 Handle<Code> code = Pipeline::GenerateCodeForCodeStub(
82 rasm->isolate(), rasm->call_descriptor(), rasm->graph(), schedule, 79 rasm->isolate(), rasm->call_descriptor(), rasm->graph(), schedule,
83 state->flags_, state->name_, verify_graph); 80 state->flags_, state->name_);
84 81
85 state->code_generated_ = true; 82 state->code_generated_ = true;
86 return code; 83 return code;
87 } 84 }
88 85
89 bool CodeAssembler::Is64() const { return raw_assembler()->machine()->Is64(); } 86 bool CodeAssembler::Is64() const { return raw_assembler()->machine()->Is64(); }
90 87
91 bool CodeAssembler::IsFloat64RoundUpSupported() const { 88 bool CodeAssembler::IsFloat64RoundUpSupported() const {
92 return raw_assembler()->machine()->Float64RoundUp().IsSupported(); 89 return raw_assembler()->machine()->Float64RoundUp().IsSupported();
93 } 90 }
(...skipping 1100 matching lines...) Expand 10 before | Expand all | Expand 10 after
1194 } 1191 }
1195 } 1192 }
1196 } 1193 }
1197 1194
1198 bound_ = true; 1195 bound_ = true;
1199 } 1196 }
1200 1197
1201 } // namespace compiler 1198 } // namespace compiler
1202 } // namespace internal 1199 } // namespace internal
1203 } // namespace v8 1200 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698