third_party/WebKit/Source/core/frame/NavigatorLanguage.idl - Issue 2570203004: Fix low risk nullable => non nullable change for NavigatorLanguage.language

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/frame/NavigatorLanguage.idl

Issue 2570203004: Fix low risk nullable => non nullable change for NavigatorLanguage.language (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://html.spec.whatwg.org/#language-preferences	5 // https://html.spec.whatwg.org/#language-preferences

6	6

7 [	7 [

8 NoInterfaceObject,	8 NoInterfaceObject,

9 Exposed=(Window,Worker),	9 Exposed=(Window,Worker),

10 ] interface NavigatorLanguage {	10 ] interface NavigatorLanguage {

11 readonly attribute DOMString? language;	11 readonly attribute DOMString language;
	foolip 2016/12/14 19:07:31 Can you mention in the description why this change Can you mention in the description why this change is safe? (Perhaps dig a bit more to see if there's any way it can return null, hopefully find nothing.) lunalu1 2016/12/15 10:33:54 Done. Show quoted text On 2016/12/14 19:07:31, foolip wrote: > Can you mention in the description why this change is safe? (Perhaps dig a bit > more to see if there's any way it can return null, hopefully find nothing.) Done.
12 // TODO(foolip): \|languages\| should be FrozenArray<DOMString>.	12 // TODO(foolip): \|languages\| should be FrozenArray<DOMString>.

13 [CachedAttribute=hasLanguagesChanged] readonly attribute DOMString[] languag es;	13 [CachedAttribute=hasLanguagesChanged] readonly attribute DOMString[] languag es;

14 };	14 };

OLD	NEW

« third_party/WebKit/Source/core/events/InputEvent.idl ('K') | « third_party/WebKit/Source/core/events/InputEventInit.idl ('k') | no next file » | no next file with comments »