Fix missing CRT libraries with ASAN unittests

remoting/host/win/BUILD.gn

Index: remoting/host/win/BUILD.gn
diff --git a/remoting/host/win/BUILD.gn b/remoting/host/win/BUILD.gn
index cf2dbcd8d8c829a40dc3d4a06289ab5358991609..2c0a29e7f1b7a89664c27aeb9e5c2b2011ec0316 100644
--- a/remoting/host/win/BUILD.gn
+++ b/remoting/host/win/BUILD.gn
@@ -261,7 +261,10 @@ message_compiler("messages") {
 }
 
 executable("remoting_console") {
-  configs += [ "//build/config/compiler:wexit_time_destructors" ]
+  configs += [
+    "//build/config/compiler:wexit_time_destructors",
+    "//build/config/sanitizers:sanitizer_default_libs",
+  ]
 
   defines = host_predefines + [ "BINARY=BINARY_HOST_ME2ME" ]
 
@@ -269,6 +272,7 @@ executable("remoting_console") {
     ":dpi_aware_exe_manifest",
     ":remoting_core",
     ":remoting_windows_resources",
+    "//build/config/sanitizers:deps",

[joedow, 2017/01/10 16:40:22]

Just curious, why was deps updated for this target but not for the others that
had the sanitizer_default_libs added to the config list?

[etienneb, 2017/01/11 16:05:32]

This is adding sanitizers code into the executable. Here is both linker response
files (without and with the line):


out\ninja\remoting_console.exe.rsp

[without :deps]

obj/remoting/host/win/remoting_console/version.res
obj/remoting/host/win/remoting_console/entry_point.obj
obj/remoting/host/win/dpi_aware_exe_manifest/dpi_aware_exe_manifest.manifest.res
remoting_core.dll.lib
advapi32.lib comdlg32.lib dbghelp.lib delayimp.lib dnsapi.lib gdi32.lib
kernel32.lib msimg32.lib odbc32.lib odbccp32.lib ole32.lib oleaut32.lib
psapi.lib shell32.lib shlwapi.lib user32.lib usp10.lib uuid.lib version.lib
wininet.lib winmm.lib winspool.lib ws2_32.lib clang_rt.asan-i386.lib libcmt.lib
libucrt.lib libvcruntime.lib
/ENTRY:HostEntryPoint /OPT:REF /OPT:ICF /INCREMENTAL:NO /FIXED:NO /WX /OPT:ICF
/DEBUG /MACHINE:X86 /SAFESEH /largeaddressaware /fastfail /FIXED:NO /ignore:4199
/ignore:4221 /NXCOMPAT /DYNAMICBASE /INCREMENTAL:NO /SUBSYSTEM:CONSOLE,5.01 
/DELAYLOAD:cfgmgr32.dll /DELAYLOAD:powrprof.dll /DELAYLOAD:setupapi.dll
/DELAYLOAD:mf.dll /DELAYLOAD:mfplat.dll /DELAYLOAD:mfreadwrite.dll
/DELAYLOAD:BluetoothApis.dll /DELAYLOAD:Bthprops.cpl /DELAYLOAD:setupapi.dll 
/LIBPATH:d:/src/llvm/ninja/lib/clang/4.0.0/lib/windows 
/LIBPATH:D:/src/depot_tools/win_toolchain/vs_files/d3cb0e37bdd120ad0ac4650b674b09e81be45616/win_sdk/Lib/winv6.3/um/x86

/LIBPATH:D:/src/depot_tools/win_toolchain/vs_files/d3cb0e37bdd120ad0ac4650b674b09e81be45616/VC/lib
/LIBPATH:D:/src/depot_tools/win_toolchain/vs_files/d3cb0e37bdd120ad0ac4650b674b09e81be45616/VC/atlmfc/lib


[with :deps]

obj/remoting/host/win/remoting_console/version.res
obj/remoting/host/win/remoting_console/entry_point.obj
obj/remoting/host/win/dpi_aware_exe_manifest/dpi_aware_exe_manifest.manifest.res
remoting_core.dll.lib 
obj/build/config/sanitizers/options_sources.lib <<<-----------------
advapi32.lib comdlg32.lib dbghelp.lib delayimp.lib dnsapi.lib gdi32.lib
kernel32.lib msimg32.lib odbc32.lib odbccp32.lib ole32.lib oleaut32.lib
psapi.lib shell32.lib shlwapi.lib user32.lib usp 10.lib uuid.lib version.lib
wininet.lib winmm.lib winspool.lib ws2_32.lib clang_rt.asan-i386.lib libcmt.lib
libucrt.lib  libvcruntime.lib
/ENTRY:HostEntryPoint /OPT:REF /OPT:ICF /INCREMENTAL:NO /FIXED:NO /WX /OPT:ICF
/DEBUG /MACHINE:X86 /SAFESEH /largeaddressaware /fastfail /FIXED:NO /ignore:4199
/ignore:4221 /NXCOMPAT /DYNAMICBASE /INCREMENTAL:NO /SUBSYSTEM:CONSOLE,5.01
/DELAYLOAD:cfgmgr32.dll /DELAYLOAD:powrprof.dll /DELAYLOAD:setupapi.dll
/DELAYLOAD:mf.dll /DELAYLOAD:mfplat.dll /DELAYLOAD:mfreadwrite.dll
/DELAYLOAD:BluetoothApis.dll /DELAYLOAD:Bthprops.cpl /DELAYLOAD:setupapi.dll
/LIBPATH:d:/src/llvm/ninja/lib/clang/4.0.0/lib/windows 
/LIBPATH:D:/src/depot_tools/win_toolchain/vs_files/d3cb0e37bdd120ad0ac4650b674b09e81be45616/win_sdk/Lib/winv6.3/um/x86

/LIBPATH:D:/src/depot_tools/win_toolchain/vs_files/d3cb0e37bdd120ad0ac4650b674b09e81be45616/VC/lib

/LIBPATH:D:/src/depot_tools/win_toolchain/vs_files/d3cb0e37bdd120ad0ac4650b674b09e81be45616/VC/atlmfc/lib



It's adding this file: obj/build/config/sanitizers/options_sources.lib 
built from: //build/sanitizers/sanitizer_options.cc

Which brings default ASAN options used by chromium project.

  const char kAsanDefaultOptions[] =
      "legacy_pthread_cond=1 malloc_context_size=5 "
      "symbolize=1 check_printf=1 use_sigaltstack=1  detect_leaks=0 "
      "strip_path_prefix=/../../ fast_unwind_on_fatal=1";



Without the ":deps" entry, these executables are compiling anyway. I suspect
this will cause issue with the components build because ":deps" is bringing:

  config("default_sanitizer_ldflags")

Which is adding the required ASAN libs:

      if (is_component_build) {
        assert(false, "win/asan does not work in 64-bit yet")
        libs = [
          "clang_rt.asan_dynamic-x86_64.lib",
          "clang_rt.asan_dynamic_runtime_thunk-x86_64.lib",
        ]
      }

I'll bring back this line in a separate CL as multiple targets may have the same
issue.

   ]
 
   sources = [
@@ -286,6 +290,7 @@ executable("remoting_me2me_host") {
   configs += [
     "//build/config/compiler:wexit_time_destructors",
     "//build/config/win:windowed",
+    "//build/config/sanitizers:sanitizer_default_libs",
     "//remoting/build/config:remoting_me2me_host",
   ]
 
@@ -419,6 +424,7 @@ shared_library("remoting_core") {
 executable("remoting_desktop") {
   configs += [
     "//build/config/compiler:wexit_time_destructors",
+    "//build/config/sanitizers:sanitizer_default_libs",
     "//build/config/win:windowed",
   ]