third_party/protobuf/README.chromium - Issue 2570123002: Fix integer overflow in FastUInt32ToBufferLeft

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/protobuf/README.chromium

Issue 2570123002: Fix integer overflow in FastUInt32ToBufferLeft (Closed)

Patch Set: CQ refresh Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 Name: Protocol Buffers	1 Name: Protocol Buffers

2 Short Name: protobuf	2 Short Name: protobuf

3 URL: https://github.com/google/protobuf	3 URL: https://github.com/google/protobuf

4 License: BSD	4 License: BSD

5 License File: LICENSE	5 License File: LICENSE

6 Version: 3.0.0-beta-3	6 Version: 3.0.0-beta-3

7 Revision: 3470b6895aa659b7559ed678e029a5338e535f14	7 Revision: 3470b6895aa659b7559ed678e029a5338e535f14

8 Security Critical: yes	8 Security Critical: yes

9	9

10 Steps used to create the current version:	10 Steps used to create the current version:

(...skipping 58 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
69	69

70 These patches uninline some functions, resulting in a significant reduction	70 These patches uninline some functions, resulting in a significant reduction

71 (somewhere between 500 KB and 1 MB) of binary size.	71 (somewhere between 500 KB and 1 MB) of binary size.

72	72

73 - 0011-libprotobuf_export.patch	73 - 0011-libprotobuf_export.patch

74	74

75 During merge with internal branch, the dll export attribute was accidentally	75 During merge with internal branch, the dll export attribute was accidentally

76 removed in C++11 mode.	76 removed in C++11 mode.

77	77

78 Fixed in https://github.com/google/protobuf/pull/1549	78 Fixed in https://github.com/google/protobuf/pull/1549

	79 - 0012-fix-overflow-FastUInt32ToBufferLeft.patch

	80

	81 This fixed a signed overflow in FastUInt32ToBufferLeft. The patch should be

	82 removed once https://github.com/google/protobuf/pull/2496 is merged.

OLD	NEW

« no previous file with comments | « no previous file | third_party/protobuf/patches/0012-fix-overflow-FastUInt32ToBufferLeft.patch » ('j') | no next file with comments »