Issue 2570103003: VM: [DBC] Remove sp_ field from the DBC simulator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2570103003: VM: [DBC] Remove sp_ field from the DBC simulator (Closed)

Created:
4 years ago by Vyacheslav Egorov (Google)

Modified:
4 years ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

VM: [DBC] Remove sp_ field from the DBC simulator This field was always equal to fp_. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/10588e7becfa654dfcf8f575040120f6a0d86e4a

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -16 lines)			Patch
	M	runtime/vm/simulator_dbc.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
	M	runtime/vm/simulator_dbc.cc	View		8 chunks	+9 lines, -14 lines	0 comments	Download

Total messages: 4 (1 generated)

Vyacheslav Egorov (Google)

4 years ago (2016-12-13 18:14:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
10588e7becfa654dfcf8f575040120f6a0d86e4a (presubmit successful).