Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: chrome/browser/prefs/tracked/tracked_preferences_migration.h

Issue 257003007: Introduce a new framework for back-and-forth tracked/protected preferences migration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comment nit Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/tracked/tracked_preferences_migration.h
diff --git a/chrome/browser/prefs/tracked/tracked_preferences_migration.h b/chrome/browser/prefs/tracked/tracked_preferences_migration.h
new file mode 100644
index 0000000000000000000000000000000000000000..348f844cc00a7bb0ee62c5b5ac80367a830d3fe4
--- /dev/null
+++ b/chrome/browser/prefs/tracked/tracked_preferences_migration.h
@@ -0,0 +1,37 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PREFS_TRACKED_TRACKED_PREFERENCES_MIGRATION_H_
+#define CHROME_BROWSER_PREFS_TRACKED_TRACKED_PREFERENCES_MIGRATION_H_
+
+#include <set>
+#include <string>
+
+#include "base/callback_forward.h"
+
+class InterceptablePrefFilter;
+
+// Sets up InterceptablePrefFilter::FilterOnLoadInterceptors on
+// |unprotected_pref_filter| and |protected_pref_filter| which prevents each
+// filter from running their on load operations until the interceptors decide to
+// hand the prefs back to them (after migration is complete). |
+// (un)protected_store_cleaner| and
+// |register_on_successful_(un)protected_store_write_callback| are used to do
+// post-migration cleanup tasks. Those should be bound to weak pointers to avoid
+// blocking shutdown. The migration framework is resilient to a failed cleanup
+// (it will simply try again in the next Chrome run).
+void SetupTrackedPreferencesMigration(
+ const std::set<std::string>& unprotected_pref_names,
+ const std::set<std::string>& protected_pref_names,
+ const base::Callback<void(const std::string& key)>&
+ unprotected_store_cleaner,
+ const base::Callback<void(const std::string& key)>& protected_store_cleaner,
+ const base::Callback<void(const base::Closure&)>&
+ register_on_successful_unprotected_store_write_callback,
+ const base::Callback<void(const base::Closure&)>&
+ register_on_successful_protected_store_write_callback,
+ InterceptablePrefFilter* unprotected_pref_filter,
+ InterceptablePrefFilter* protected_pref_filter);
+
+#endif // CHROME_BROWSER_PREFS_TRACKED_TRACKED_PREFERENCES_MIGRATION_H_

Powered by Google App Engine
This is Rietveld 408576698