chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc - Issue 257003004: Remove dependency on bookmark_model_factory from bookmark_test_helpers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc

Issue 257003004: Remove dependency on bookmark_model_factory from bookmark_test_helpers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@364433

Patch Set: Fix unit tests on Linux & Windows Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm ('k') | chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc

index 07a02b91194e743c673df82202ff41c036f9017a..ee36ee17da6a489068facabb145def3e356fc2be 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h"

#include "base/prefs/pref_service.h"

+#include "chrome/browser/bookmarks/bookmark_model_factory.h"

#include "chrome/browser/bookmarks/bookmark_test_helpers.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/search_engines/template_url_service.h"

@@ -46,7 +47,8 @@ class BookmarkBarViewInstantExtendedTest : public BrowserWithTestWindowTest {

TEST_F(BookmarkBarViewInstantExtendedTest, AppsShortcutVisibility) {

ScopedTestingLocalState local_state(TestingBrowserProcess::GetGlobal());

profile()->CreateBookmarkModel(true);

- test::WaitForBookmarkModelToLoad(profile());

+ test::WaitForBookmarkModelToLoad(

+ BookmarkModelFactory::GetForProfile(profile()));

BookmarkBarView bookmark_bar_view(browser(), NULL);

bookmark_bar_view.set_owned_by_client();

browser()->profile()->GetPrefs()->SetBoolean(